stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Revamped Arabic localization

Open xmodar opened this issue 2 years ago • 6 comments

This version abandons literal translation and adds explanations where possible. The translations are ordered by the way they appear in the UI. The final file was trimmed and cleaned of non-translatable parts like the samplers names.

Used the following resources:

  • https://www.almaany.com/
  • https://translate.google.com/
  • https://techtionary.thinktech.sa/
  • https://sdaia.gov.sa/files/Dictionary.pdf

xmodar avatar Oct 25 '22 23:10 xmodar

For now, I am keeping this as a draft pull request. I would love to hear feedback from Arabic speakers out there (wink @blackneoo). I definitely took the liberty of coining some terms like التشعث الرزين 😅. Personally, I think it is good to go but I need a second opinion. It will help for sure. I am planning to submit it for review tomorrow if I didn't hear back from anyone by then.

xmodar avatar Oct 25 '22 23:10 xmodar

@xmodar, actually i am glad someone is stepping up to do this, the reason i started the Arabic translation is to get things moving hoping to make it easier for devs who have a bit more time to focus on enhancing it, the original translation was as you described generally literal to allow for better cross referencing with English terms to ease enhancing, i took a fast look at your modifications and i generally really like the direction you took in simplifying the concepts and i really like a lot of the alternative terms you are using some i really don't like (التشعث الرزين , قسط المشوار) and some i don't think reflects the actual function (Highres. fix": "أقل دقة), but i think overall it's a very good work, i will take a more in-depth look at it today and provide feedback.

blackneoo avatar Oct 26 '22 07:10 blackneoo

@xmodar I reviewed the translation and i must say for the most part you did an excellent job revamping it :ok_hand: i have some comments, so i created the attached excel with the feedback to ease discussion Localization_Arabic_Review.xlsx

blackneoo avatar Oct 26 '22 14:10 blackneoo

I knew that I will get some pushback on التشعث الرزين and I am glad that somebody did. @blackneoo, thanks for the kind words and valuable feedback. The attention to detail is much appreciated. I have incorporated the raised points when writing bf7cbcd. Please, give it a look and let me know what you think.

xmodar avatar Oct 26 '22 22:10 xmodar

@xmodar, I took a look at the changes seems good to go 👍 , by the way really liked how you handled de-noising with المدى 😉

blackneoo avatar Oct 27 '22 11:10 blackneoo

@AUTOMATIC1111, thanks for @blackneoo initiative and feedback, I think this localization file is ready to be shipped. You will notice that I also changed style.css and modules/scripts.py. This is to fix the RTL and LTR directionality of some important components on the page. I added a component id through elem_id to be able to reference the dropdown box in the CSS. I should add here that these changes are not language specific and should be universal for all RTL languages.

xmodar avatar Oct 27 '22 12:10 xmodar