stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard
Published 2 weeks ago • verified publisher icon AUTOMATIC1111

fix bug of progress bar when running img2img and highres fix (#3093, #3145)

Open ritosonn opened this issue 3 years ago • 1 comments

Fixed bugs #3093 and #3145 so some progress bars are handled correctly.

  • The total number of steps for img2img is t_enc + 1, not steps.
  • I checked KDiffusionSampler to check for this bug, but VanillaStableDiffusionSampler may also need to be fixed (haven't check yet).

ritosonn avatar Oct 21 '22 15:10 ritosonn

I always get the right number of steps in hires fix, and regardless of img2img_fix_steps setting.

Applying this fix would break it for me.

AUTOMATIC1111 avatar Oct 22 '22 17:10 AUTOMATIC1111

Tested, fixed for me.

MrFelt avatar Oct 25 '22 02:10 MrFelt

This pull request fixes #3343 for me and at least 1 other person in that thread.

timntorres avatar Oct 25 '22 02:10 timntorres

this was actually the right fix i just misinterpreted the code

AUTOMATIC1111 avatar Oct 25 '22 05:10 AUTOMATIC1111