stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Able to apply blank value or add blank space to number as ENSD, resulting in generation failure

Open preyx opened this issue 2 years ago • 2 comments

Describe the bug While the settings page rejects non-number values (such as "A") for ENSD, it does not reject a blank/null input or numbers with a space added, resulting in generation failure for ancestral type samplers that rely on it.

To Reproduce Steps to reproduce the behavior:

  1. Go to "Settings" tab and set "Eta noise seed delta" to "" (empty, not zero) or "31337 " (add blank space at the end of any valid number)
  2. Click "Apply settings", UI gives confirmation
  3. Select "Sampling method" = Euler a, DPMS2 a, DPMS2 a Karras, or DDIM. Use any valid prompt and other settings.
  4. Generation immediately fails, no image, text output = TypeError: '>' not supported between instances of 'NoneType' and 'int'

Expected behavior Assume empty input is ENSD=0 during generation. OR Error on settings page when attempting to apply change, rejecting blank input.

Additional context An error is generated in the console, but neither backend nor frontend crashes. Applying any number (including zero) as ENSD following this error allows me to resume normal use.

edit: Added details regarding adding a space on the end of a valid number.

preyx avatar Oct 10 '22 23:10 preyx

Repeatable in my fresh install.

ooofest avatar Oct 11 '22 02:10 ooofest

Same issue here.

Moebits avatar Oct 20 '22 01:10 Moebits

Fixed

mezotaken avatar Jan 16 '23 19:01 mezotaken