hires button, opt insert gallery

[w-e-w]

Description

• https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/16404

add option to insert the resulting images into Gallery as opposed to replace original when using high button to perform upscale

Setting > Gallery > Insert [✨] hires button results to gallery default False

Screenshots/videos:

---

• as far as I can tell geninfo["infotexts"][gallery_index: gallery_index+1] = processed.infotexts was a line I forgot to when remove when I was working on https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/cfb90a938eff6d5d4cfa39f58ebc0ab32ffedfb3 luckily it wasn't causing any issues

Checklist:

• [x] I have read contributing wiki page
• [x] I have performed a self-review of my own code
• [x] My code follows the style guidelines
• [x] My code passes tests

[strawberrymelonpanda]

Works and appreciated @w-e-w, always wanted to be able to rerun high-res fix with different settings.

One request perhaps: right now seems to select the previous, initial low-res image after the high-res fix, not the new image. Would it be possible to switch to the new image instead?

(The browser I tested with was Chromium)

[w-e-w]

Would it be possible to switch to the new image instead?

yes, but unfortunately as we are currently using gradio==3.41.2 and so don't have access to the gallery selected_index argument

this means if we want to change the selected image it would require some messy custom JavaScript and other changes to the codebase then I would like fore this sort of thing

I would rather wait until after we upgread gradio version, which is something that we have been saying for a long time ......

• https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14184

---

~~translation: yes it's possible but I'm lazy so I'd rather wait until the built-in tools available then implement my own~~

[strawberrymelonpanda]

No worries; makes sense. I think Auto typically prefers fewer JS solutions as well. It's a nice improvement as-is.

[780ilk8ui9otk]

Finally waited for this, can you provide this feature for adetailer as well?

[catboxanon]

Not switching to the new image seems a bit silly. I think this should be implemented properly when Gradio 4 support is merged (if ever) and not be an option but rather default behavior.

[w-e-w]

Not switching to the new image seems a bit silly.

that may be doable with JavaScript (if you know how feel free to add it) but it's still better than nothing I guess

I think this should be implemented properly when Gradio 4 support is merged (if ever) and not be an option but rather default behavior.

I wouldn't call this no properly, as it's basically just adding to what we've been doing now the only thing this really does is just not removing the input image, it's not really adding complexity

and consider this basically no timeline for Gradio 4, and someone did request for the this little future better not keep them waiting