stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Fix Hypertile xyz

Open w-e-w opened this issue 1 year ago • 3 comments

Description

Hypertile's xyz support was was implemented in a way that once the axis is processed the setting is permanently changed even after job has finished

changes

  • re-implement Hypertile's xyz support using apply_override so setting are not permanent
  • create new xyz util confirm_range for checking of all values are in range
  • minor reformat of scripts/xyz_grid.py (there's a couple of weird indents)

about confirm_range initially I was going to implement something that can specify more complex ranges using the mathematical interval notation but at the end I feel like it's overkill https://gist.github.com/w-e-w/cac0787539a8163b94315c8d587ba952

Checklist:

w-e-w avatar May 18 '24 10:05 w-e-w

@aria1th just in case there is something I don't know why is there the need of chacking existing Hypertile axis as far as I'm aware there's no chance of this ever happening since https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/1c0a0c4c26f78c32095ebc7f8af82f5c04fca8c0/extensions-builtin/hypertile/scripts/hypertile_xyz.py#L46-L49

w-e-w avatar May 18 '24 10:05 w-e-w

While I was implementing this, reloading extensions has resulted multiple identical options in gradio dropdown box so I temporarily added check for this I think the bug has been resolved somewhere, and we don't have to maintain the check now

aria1th avatar May 18 '24 11:05 aria1th

While I was implementing this ... I think the bug has been resolved somewhere

thanks

w-e-w avatar May 18 '24 12:05 w-e-w