stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

LoRA bundled TI infotext

Open w-e-w opened this issue 9 months ago • 2 comments

Description

alternative implementation of

  • https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15674 by @mx

differences

  • as opposed just to writing bundled to infotext TI hashes, write the LoRA name as the hash to indicate its origins

imo writing bundle alone is not very useful if you have multiple loras

  • add an option for user to toggle this behavior (default enable) setting key : lora_bundled_ti_to_infotext description:
Add Lora name as TI hashes for bundled Textual Inversion ("Add Textual Inversion hashes to infotext" needs to be enabled)

as onec a LoRA is loaded is is cashed and won't be reloaded using a custom BundledTIHash class allows for the string dynamically change based on settings with no change to other code


things to consider

  • maybe instead of putting the lora name, put the hash of the lora
  • alternatively maybe calculate the real hash of the bundled TI
  • if the lora name is used should we add some sort of prefix to distinguish edge case when if someone use a hash like string for there lora name

@mx any opinion on this implementation

~~damn that's a short username how did you get such a short username~~

Checklist:

w-e-w avatar May 01 '24 10:05 w-e-w

@mx any opinion on this implementation

Seems fine to me, I'll withdraw my PR. Do we even need the additional setting though? The user already has to opt-in to a setting in order to have the TI hashes appear in the infotext at all.

mx avatar May 01 '24 14:05 mx

Seems fine to me, I'll withdraw my PR. Do we even need the additional setting though? The user already has to opt-in to a setting in order to have the TI hashes appear in the infotext at all.

this is my line thought

in a way bundled TI 's are are not as important as in a way it is a part of the model, they will never be separated by the average user so for the average user doesn't really need to care if there's a hidden TI they or not and they might not want to be spammed with the extra extended TI infotext

in fact I'm actually considering making disable as default

w-e-w avatar May 01 '24 14:05 w-e-w