DPM, DPM Adaptive and PLMS fail with high-res fix with various different errors
DPM, DPM Adaptive and PLMS fail with high-res fix with various different errors. Easily reproducable, just select one of the above samplers, select high-res fix, then run the prompt.
Expected behavior Expect prompt to run as normal
Desktop (please complete the following information):
- OS: Win 11
- Browser Firefox
- Commit revision 3f417566b0bda8eab05d247567aebf001c1d1725 Additional context They all work fine when high-res fix not applied.
Appears to literally be a missing or misplaced in the function call issue? Does the number of params change when we enable highres fix?
Just ran into this tonight, error on the console was:
File "F:\stable-diffusion-webui\modules\sd_samplers.py", line 377, in sample_img2img return self.func(self.model_wrap_cfg, xi, sigma_sched, extra_args={'cond': conditioning, 'uncond': unconditional_conditioning, 'cond_scale': p.cfg_scale}, disable=False, callback=self.callback_state, **extra_params_kwargs) File "F:\stable-diffusion-webui\venv\lib\site-packages\torch\autograd\grad_mode.py", line 27, in decorate_context return func(*args, **kwargs) TypeError: sample_dpm_adaptive() missing 1 required positional argument: 'sigma_max'
If that helps at all?
Well I think I may have found the problem. It seems to be some sort of rounding error with the "high res fix" denoising strength. It needs to be above 1.5 (that is, 1.6 or more) for it to work or it fails with an index error. It must be rounding down either to 1 or to zero perhaps.
https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/b186d44dcd0df9d127a663b297334a5bd8258b58 everything else is fixed