stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Init images missing PNG Info

Open Drake53 opened this issue 1 year ago • 1 comments

Checklist

  • [ ] The issue exists after disabling all extensions
  • [ ] The issue exists on a clean installation of webui
  • [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • [ ] The issue exists in the current version of the webui
  • [ ] The issue has not been reported before recently
  • [ ] The issue has been reported before but has not been fixed yet

What happened?

Opening an init image in PNG Info does not show any parameters, even though the original image did contain these.

Steps to reproduce the problem

  • Enable the setting 'Save init images when using img2img' (save_init_img)
  • Start generating a new image in img2img
  • Open the init image (from outputs/init-images) in PNG Info
  • The file does not contain any parameters

What should have happened?

The init file saved to the init-images folder should be a copy of the original file, so that its PNG Info remains intact.

What browsers do you use to access the UI ?

Other

Sysinfo

v1.7.0, commit cf2772fab0af5573da775e7437e6acdca424f26e

Console logs

Not applicable since it doesn't involve an exception.

Additional information

No response

Drake53 avatar Dec 28 '23 11:12 Drake53

pr https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14452

w-e-w avatar Dec 28 '23 17:12 w-e-w

Thanks for the quick fix, any chance this can also be done for init images (which may have been slightly modified) in sketch mode?

Drake53 avatar Dec 29 '23 15:12 Drake53

unfortunately it seems gradio nukes the info so I don't think it's possible without patching gradio

which means it's going to involve lots of effort and potentially causing instability for little return at least this is the behavior of gradio 3, maybe things will change when we move to gradio 4

image you can see the info is gone

w-e-w avatar Dec 29 '23 16:12 w-e-w

some bad news gradio 4 changes the image element to from Image to ImageEditor which behaves very differently including it removes the info so once we switch to gradio 4 my PR won't work anymore unless a workaround can be found

and considering the plan is to switch to gradio 4 in the future I don't think it's a good idea merge my pr https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14452

w-e-w avatar Dec 29 '23 16:12 w-e-w

https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14452 merged

w-e-w avatar Dec 30 '23 13:12 w-e-w