stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.

Open canoalberto opened this issue 2 years ago • 2 comments

Description

Added shared.cmd_opts.data_dir prefix to "outputs" and "log" paths.

Fixes the issue where hardcoded default "outputs" and "log" paths may not be writable and enables placing them under --data-dir option path.

Screenshots/videos:

NA

Checklist:

canoalberto avatar Dec 27 '23 18:12 canoalberto

related conversation https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14442#issuecomment-1870607628


lol didn't realize you basically have the same idea as me

w-e-w avatar Dec 27 '23 20:12 w-e-w

I made an alternative implementation with some changes see PR https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/14446

namely truncating the path to CWD when possible (so if one is not using --data-dir it behave the same as before)

I added you as co-author

w-e-w avatar Dec 27 '23 21:12 w-e-w

I merged the other one. Just was wew proposes, I'd rather not absolute paths to config by default.

AUTOMATIC1111 avatar Dec 30 '23 11:12 AUTOMATIC1111