stable-diffusion-webui
stable-diffusion-webui copied to clipboard
AUTOMATIC1111
updated dependencies in requirement file
Description
- Updated dependencies in requirements_version.txt file
- Updated available package version depends upon compatibility
- Fixes #14374
Checklist:
- [x] I have read contributing wiki page
- [x] I have performed a self-review of my own code
- [x] My code follows the style guidelines
- [x] My code passes tests
well it does seem to work on the surface, but that's all I can say
with these type of things it's very hard to know if something would cause trouble because there's just so many changes and because of how python works you won't know the trouble until you actually hit one so lots of times "don't fix what isn't broken" is a good rule to follow that being said newer versions of packages typically comes with more features that might be beneficial so it possible then bumping version is good, but this is something that requires lots of testing by multiple people
like 2 months ago I was considering making a request to bump Pillow because of an issue with drawing rectangles with rounded corners, but I didn't because I didn't have time to test if that can potentially cause unforcing issues https://github.com/AUTOMATIC1111/stable-diffusion-webui/tree/bump-Pillow-blendmodes-dependency
if this is going to be merged this is going to require lots of testing and considering they're already lots of big things that I've been updated recently such as torch and we're also in the progress of updating gradio I would advise to take things slowly
Understood this problem may be avoid if there were lot of unit tests which test small functionalities using these packages. In current situation it requires lot of manual testing.
lot of unit tests
that's true, but the problem is someone has to write the test first
currently we only have a high level test to test the server launching and basic image generation
I'd rather not bump versions for dependencies unless we need something useful from them.
