stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Captions not being generated for flipped copies

Open jaffster595 opened this issue 1 year ago • 1 comments

Checklist

  • [X] The issue exists after disabling all extensions
  • [X] The issue exists on a clean installation of webui
  • [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • [X] The issue exists in the current version of the webui
  • [X] The issue has not been reported before recently
  • [ ] The issue has been reported before but has not been fixed yet

What happened?

Following on from bug #14333, the steps mentioned in this commit do fix the issue (https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/3d9a0d9e4b1a52a873d32c7ba5c462d840f0e3ee) but a follow on issue was noticed.

When the 'Create Flipped Copies' box is selected, it only generates captions for the original image and NOT for the flipped copy In prior versions it would create captions for both the original and flipped copies.

Steps to reproduce the problem

  1. Click the 'Extras' tab
  2. Choose 'Batch from directory'
  3. Choose folders for the input/output field
  4. Tick the 'Captions' box and choose 'BLIP'
  5. Tick 'Create Flipped Copies'
  6. Generate

What should have happened?

It should first generate the flipped copy and then generate captions for both the original image and the flipped copy.

What browsers do you use to access the UI ?

Google Chrome

Sysinfo

sysinfo-2023-12-18-16-26.json

Console logs

There's no errors in the console to report.

Additional information

No response

jaffster595 avatar Dec 18 '23 16:12 jaffster595

simply put this is caused by the order of execution of the modules and since flipping comes after captioning the captioning is not applied to defect results because it didn't exist yet we can update the default order but for now users can manually configured the order go to setting > Postprocessing > Postprocessing operation order and reorder the modules image don't copy my order blindly it depends on the use case, the important bit is that if you wish captioning to apply to flipped results then flipping needs to come before captioning

w-e-w avatar Dec 19 '23 09:12 w-e-w