stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Update Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed webui.py

Open ranareehanaslam opened this issue 1 year ago • 5 comments

Added (Fixed) IPV6 Functionality When there is No Webui Argument Passed

Description

There was a issue in the Script webui.py when anyone want to run the api only with no webui arguments it was only loading it to the local server only if no listen is passed and either server-name is passed it was being ignored i have fixed It Further Proof of Concept and Screenshot's are attached

testing COMMANDLINE_ARGS --disable-safe-unpickle --server-name [::] --xformers --opt-sdp-attention --enable-insecure-extension-access --api --opt-channelslast --nowebui --no-gradio-queue --port 7860 --ui-settings-file 'config.json' --ui-config-file 'ui-config.json' --no-download-sd-model

Screenshots/videos:

BEFORE FIX image AFTER FIX image

Checklist:

ranareehanaslam avatar Dec 18 '23 12:12 ranareehanaslam

@AUTOMATIC1111 Waiting for your Response sir!

ranareehanaslam avatar Dec 18 '23 12:12 ranareehanaslam

Please actually read the contributing guidelines.

You're violating at least 2 of the bullet points.

akx avatar Dec 18 '23 18:12 akx

Please actually read the contributing guidelines.

You're violating at least 2 of the bullet points.

is it really mean it ..? am just helping the community

ranareehanaslam avatar Dec 19 '23 04:12 ranareehanaslam

is it really mean it ..? am just helping the community

That may be, but you need to abide by the project's rules. The violations I can see are related to the branch you're targeting, and the branch you're making your PR from.

akx avatar Dec 19 '23 07:12 akx

Please actually read the contributing guidelines. You're violating at least 2 of the bullet points.

is it really mean it ..? am just helping the community

I'm sorry but I think you still don't understand what he is talking about. Any changes for PRs have to be done in the dev branch, you did change the code in master branch and started a PR from there, merging changes from master into dev is NOT allowed, please redo your changes in dev branch and then open a proper NEW PR.

dhwz avatar Dec 19 '23 13:12 dhwz

So the actual issue from previous PRs was that the API-only was just ignoring some cmdline args, which does seem like a real problem. I merged this, and applied the change akx suggested.

AUTOMATIC1111 avatar Dec 30 '23 12:12 AUTOMATIC1111