stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

Gradio 4

Open AUTOMATIC1111 opened this issue 1 year ago • 25 comments
trafficstars

Gradio 4 update.

The update breaks a lot of compatibility, some for very questionable reasons. Among other things, this branch makes it again possible to send bogus keyword arguments to components, and only get a warning for it, and use a _js argument for events. Basic functionality works, some extensions I have enabled like imagenet and tagcomplete load.

AUTOMATIC1111 avatar Dec 03 '23 14:12 AUTOMATIC1111

Hi, can you tag me when img2img is working? I will try to fix canvas-zoom-and-pan

daswer123 avatar Dec 04 '23 13:12 daswer123

@daswer123 Basic img2img is working. Still need to fix sketch, inpaint, etc.

missionfloyd avatar Dec 05 '23 04:12 missionfloyd

Yeah, thanks, in general everything is more or less for build-in "canvas-zoom-and-pan", a number of features will have to be abandoned because it is no longer needed, some will have to be redone.

daswer123 avatar Dec 05 '23 06:12 daswer123

Oh, nice, there's been some work on this. Thanks. I couldn't do any myself because I was too busy.

AUTOMATIC1111 avatar Dec 14 '23 06:12 AUTOMATIC1111

fwiw - as far as extensions go, while testing the Image Browser extension, I ran into ASGI errors, when many events were triggered. I addressed this with the Gradio team and it is fixed in Gradio 4.9.0.

AlUlkesh avatar Dec 14 '23 22:12 AlUlkesh

fwiw - as far as extensions go, while testing the Image Browser extension, I ran into ASGI errors, when many events were triggered. I addressed this with the Gradio team and it is fixed in Gradio 4.9.0.

so bump to gradio 4.9.1?

w-e-w avatar Dec 15 '23 04:12 w-e-w

I added a bit more fixes. So far, copy image to buttons are broken - from txt2img to img2img, and from img2img to img2img. For different reasons.

AUTOMATIC1111 avatar Jan 07 '24 18:01 AUTOMATIC1111

Fixed send to tabs buttons, updated to latest dev; Current problems:

  • inpaint tab is still misbehaving if you send an image to it from anywhere (could be just a gradio bug)
  • bunch of errors in JS console at startup (could also be a gradio bug)

Mostly it feels like it works.

AUTOMATIC1111 avatar Jan 27 '24 09:01 AUTOMATIC1111

Hi all, made a PR where I tweaked the work of the built-in zoom extension #14816 #14818

In general everything works, I study possible variants and in case I find bugs I will fix, also there are some thoughts on how to improve this extension.

In gradio 4 elements that work with the image have a lot of new buttons and functions, I thought it might be cool to realize convenient work with these functions through hotkeys.

For example, quick switching between drawing and erasing, quick layer creation, switching between layers via hotkeys. This is the first thing that came to my mind, I think there are many other things that can be realized.

I would like to know your opinion, is it worth working on the built-in extension or is it better to use these ideas to work on a separate extension?

daswer123 avatar Feb 01 '24 13:02 daswer123

Does ui still lag with some extensions installed on gradio 4?

aolko avatar Feb 01 '24 15:02 aolko

I think this can be merged now. Anyone care to test one more time?

AUTOMATIC1111 avatar Mar 02 '24 05:03 AUTOMATIC1111

image editor is extremely unstable still in gradio

https://github.com/gradio-app/gradio/issues?q=is%3Aissue+is%3Aopen+ImageEditor

Basically, everything seems to work well except for copying images between painting tabs.

AUTOMATIC1111 avatar Mar 03 '24 06:03 AUTOMATIC1111

i want to check and see how long we have until this gets into main branch do we have an eta?

richrobber2 avatar Mar 30 '24 18:03 richrobber2

Probably when they fix the bug with image inputs. Gradio 4 is a sad affair. It very likely will break extensions big time. Ooba updated to 4 and then reverted.

Edit: actually looks like he updated 4 days ago: https://github.com/oobabooga/text-generation-webui/commit/2a92a842cec3f95739dd1034067a1d8568e44c7a

AUTOMATIC1111 avatar Mar 31 '24 05:03 AUTOMATIC1111

Image editor issues should be fixed as of 4.27.0 now. https://github.com/gradio-app/gradio/releases/tag/gradio%404.27.0

catboxanon avatar Apr 21 '24 18:04 catboxanon

That seems to fix the send image buttons.

missionfloyd avatar Apr 21 '24 20:04 missionfloyd

ya auto's issue post is closed

  • https://github.com/gradio-app/gradio/issues/7591

w-e-w avatar Apr 22 '24 00:04 w-e-w

Is there any timeline when gradio 4.0 update will be ready?

huchenlei avatar Apr 27 '24 22:04 huchenlei

I am testing sd-webui-controlnet against gradio4 setup. However, a bunch of front-end issue seems to occur whenever I interact with almost anything on the extension UI. Any idea on this?

image

huchenlei avatar Apr 28 '24 04:04 huchenlei

I don't know when I will merge this in. With SD3, it definitely should be after that.

I also want to get some info about which big extensions this breaks, and possibly fix compatibility issues from our side.

AUTOMATIC1111 avatar Jun 08 '24 09:06 AUTOMATIC1111

I bet Gradio 4 would break so many stuff

SD3 must be more priority I agree thank you so much @AUTOMATIC1111

FurkanGozukara avatar Jun 08 '24 10:06 FurkanGozukara

Can't wait for FileExplorer 🤤

Avaray avatar Aug 02 '24 06:08 Avaray