stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Junction links not working after the 1.2.0 update

Open Proquror opened this issue 1 year ago • 4 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues and checked the recent builds/commits

What happened?

When generating an image, it does not appear in the view window, although it is saved to the output folder, placed as a Junction link in the root directory. I also have a Junction links for many subfolders inside the models folder.

Steps to reproduce the problem

  1. Download and install A1111 1.2.1 release from Releases.
  2. Move the output folder to location outside of the A1111 repo. For example: D:\1 SD AI\outputs\output.
  3. Using Link Shell Extension or CMD (as admin) create the Junction Link of the D:\1 SD AI\outputs\output folder inside your A1111 repo folder.
    • If using CMD (as admin): type mklink /J "where to put Junction link" "which folder this junction will refer to" For example: mklink /J "H:\AI\stable-diffusion-webui-1.2.1-test\output" "D:\1 SD AI\outputs\output".
    • To ensure that the junction link is present in H:\AI\stable-diffusion-webui-1.2.1-test\output and works properly:
    • You may create any folder inside the H:\AI\stable-diffusion-webui-1.2.1-test\output and check its presence at D:\1 SD AI\outputs\output.
  4. Run webui-user.bat and generate any image.
  5. Verify that the image can be seen while generation process is running, but when it's 100% generated - the image disappears.
  6. Verify that the generated image is present in the D:\1 SD AI\outputs\output.

What should have happened?

  1. Move the output folder to location outside of the A1111 repo. For example: D:\1 SD AI\outputs\output.
  2. Using Link Shell Extension or CMD (as admin) create a Junction Link of the D:\1 SD AI\outputs\output folder inside your A1111 repo folder.
  3. Run webui-user.bat and generate any image.
  4. Verify that the image can be seen while generation process is running and can be seen in web-ui after the generation process is complete.
  5. Verify that the generated image is present in the D:\1 SD AI\outputs\output.
  6. Continue your work as always.

Commit where the problem happens

89f9faa63388756314e8a1d96cf86bf5e0663045 and b08500cec8a791ef20082628b49b17df833f5dda

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

I usually use:

--xformers --no-half-vae

But it was empty for the test.

List of extensions

Default A1111 extensions list for the test.

Extension URL Version
LDSR built-in  
Lora built-in  
ScuNET built-in  
SwinIR built-in  
prompt-bracket-checker built-in  

My extensions list I use.

Extension URL Version
Config-Presets https://github.com/Zyin055/Config-Presets.git 1683ad6e (Thu May 11 00:00:45 2023)
Cozy-Nest https://github.com/Nevysha/Cozy-Nest.git bba4936f (Sun May 14 02:44:51 2023)
SD-latent-mirroring https://github.com/dfaker/SD-latent-mirroring.git 05df9e83 (Sat Mar 25 14:37:33 2023)
a1111-sd-webui-lycoris https://github.com/KohakuBlueleaf/a1111-sd-webui-lycoris.git 1f3e452c (Tue May 9 12:30:54 2023)
a1111-sd-webui-tagcomplete https://github.com/DominikDoom/a1111-sd-webui-tagcomplete 5640a438 (Thu May 11 19:18:09 2023)
canvas-zoom https://github.com/richrobber2/canvas-zoom.git 11586016 (Tue May 9 10:35:35 2023)
depthmap2mask https://github.com/Extraltodeus/depthmap2mask.git 377e9224 (Thu Apr 13 04:10:08 2023)
multi-subject-render https://github.com/Extraltodeus/multi-subject-render.git 03427e26 (Mon Mar 6 14:11:30 2023)
novelai-2-local-prompt https://github.com/animerl/novelai-2-local-prompt.git 0e03ca1a (Sat Jan 28 06:33:03 2023)
posex https://github.com/hnmr293/posex.git 292f92d5 (Wed May 3 08:59:57 2023)
sd-webui-ar https://github.com/alemelis/sd-webui-ar.git 9df49dc2 (Wed Apr 12 09:23:17 2023)
sd-webui-aspect-ratio-helper https://github.com/thomasasfk/sd-webui-aspect-ratio-helper.git b03cce20 (Mon Apr 10 21:17:00 2023)
sd-webui-controlnet https://github.com/Mikubill/sd-webui-controlnet 721159f7 (Sat May 13 17:13:43 2023)
sd-webui-depth-lib https://github.com/jexom/sd-webui-depth-lib.git efa9f616 (Mon Apr 10 05:27:11 2023)
sd-webui-infinite-image-browsing https://github.com/zanllp/sd-webui-infinite-image-browsing.git d67fcf93 (Thu May 11 18:16:40 2023)
sd-webui-regional-prompter https://github.com/hako-mikan/sd-webui-regional-prompter.git 983e7029 (Fri May 12 16:47:03 2023)
stable-diffusion-webui-aesthetic-gradients https://github.com/AUTOMATIC1111/stable-diffusion-webui-aesthetic-gradients.git 2624e5dd (Fri Jan 6 10:59:30 2023)
stable-diffusion-webui-composable-lora https://github.com/opparco/stable-diffusion-webui-composable-lora.git d4963e48 (Mon Feb 27 17:40:08 2023)
stable-diffusion-webui-pixelization https://github.com/AUTOMATIC1111/stable-diffusion-webui-pixelization.git e37251c5 (Sat Feb 4 17:02:01 2023)
stable-diffusion-webui-wd14-tagger https://github.com/toriato/stable-diffusion-webui-wd14-tagger.git a9eacb1e (Wed Jan 25 14:47:36 2023)
ultimate-upscale-for-automatic1111 https://github.com/Coyote-A/ultimate-upscale-for-automatic1111.git 756bb505 (Fri May 5 00:22:21 2023)
LDSR [built-in]
Lora [built-in]
ScuNET [built-in]
SwinIR [built-in]
prompt-bracket-checker [built-in]

Console logs

My local setup logs - https://pastebin.com/ZYzeetv2 Fresh A1111 logs - https://pastebin.com/N3v6N0zu

Additional information

  • On Web-UI 1.1.0 (commit) everything still works fine.
  • Models that loaded via Junction link folder may cause a lag without any error.
  • I tried to use both Link Shell Extension and CMD as admin to create Junction links.
  • Posex with ControlNet may not work properly after 1.2.0 (commit; but I guess it started earlier.) but works fine on 1.1.0 (commit).
  • I've just found this issue after writing. I think it's somehow related.

Proquror avatar May 14 '23 20:05 Proquror

Very likely duplicate of https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/10346 ( I don't have windows to verify) and is fixed in the dev branch. See https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/10346 for fix till that change gets pulled to release/rc.

Kadah avatar May 14 '23 21:05 Kadah

Very likely duplicate of #10346 ( I don't have windows to verify) and is fixed in the dev branch. See #10346 for fix till that change gets pulled to release/rc.

I've tried to fix my issue by editing modules/shared.py to - for root, dirs, files in os.walk(path): + for root, dirs, files in os.walk(path, followlinks=True):

and modules/ui_extra_networks.py to - for root, dirs, files in os.walk(parentdir): + for root, dirs, files in os.walk(parentdir, followlinks=True):

but unfortunately it didn't solve my issue; maybe I did something wrong (not on dev)

UPD: I'll download dev now and check if the issue is solved there.

UPD 2: Unfortunately, still not solved on dev.

UPD 3: The symlinks are working fine for pictures on the latest (89f9faa63388756314e8a1d96cf86bf5e0663045) commit and dev (f6a2a98f1a406389da266ecc993da84d2ecef432) but not Junctions.

Proquror avatar May 14 '23 21:05 Proquror

Did junctions work previously?

is there a reason to use junctions over symlinks? Back in the day I used symlinks a lot in Windows and never junctions for some reason I have forgotten over the years.

Kadah avatar May 15 '23 01:05 Kadah

can't reproduce Junctions seems to work fine for me win11

w-e-w avatar May 15 '23 05:05 w-e-w

I think this might be related, but since 1.2 my extra networks lora view shows a lot of the subdirectories, like .git, models, scripts, etc. I say it might be related because I too use junctions and my lora folder is not in the standard location (or even a the same root folder).

qqualia avatar May 16 '23 04:05 qqualia

#10286 is in master (version 1.3.0), so this should be fixed now.

akx avatar May 28 '23 12:05 akx