protonup icon indicating copy to clipboard operation
protonup copied to clipboard

Adding an option to delete all older versions of proton after installing a new one

Open vega-d opened this issue 2 years ago • 7 comments

after installation of a new version user will be prompted:

Would you like to delete N previous version(s) of protonGE? (y/N)

With N being a number of previous versions installed. If user just taps enter or writes N it will skip this portion of code, but if user opts into by typing Y it will ask again as a confirmation and then wipe all protonGE versions user had before. I personally find it useful as it will enable easier way to de-clutter.

In other small changes, output of def installed_versions(): is now sorted latest to oldest version.

vega-d avatar Aug 21 '21 11:08 vega-d

Why is it necessary to change "hotfix" to "update"? It's checking for minor fixes released under the same tag.

AUNaseef avatar Aug 29 '21 00:08 AUNaseef

Why is it necessary to change "hotfix" to "update"? It's checking for minor fixes released under the same tag.

Update is a more general term. If it could distinguish between a small hotfix and a major update then why not say hotfix or update depending on changes but since it does not update is a more accurate term.

A hotfix is always an update but an update is not always a hotfix.

vega-d avatar Aug 30 '21 07:08 vega-d

I first want to test the new proton version before deleting every other version. I would like prefer if the user could give a number. e.G. You insert 2 and then he don't delete the 2 latest version (+ the new downloaded one)

JokerGermany avatar Sep 01 '21 07:09 JokerGermany

distinguish between a small hotfix and a major update

It does that... that code (executed when the version is already installed) is specifically looking for hotfixes. I guess it's not necessary to print No hotfix found when there are no hotfixes tho

AUNaseef avatar Sep 12 '21 23:09 AUNaseef

It does that... that code (executed when the version is already installed) is specifically looking for hotfixes. I guess it's not necessary to print No hotfix found when there are no hotfixes tho

Welp, I reverted the commit

vega-d avatar Oct 03 '21 07:10 vega-d

I first want to test the new proton version before deleting every other version. I would like prefer if the user could give a number. e.G. You insert 2 and then he don't delete the 2 latest version (+ the new downloaded one)

Perhaps keep the latest 2 versions then? I think Ubuntu Mainline App does the same with displaying Preview Kernels, it provides an option to select 'Last (N) Amount of Updates'

Daasin avatar Mar 19 '22 11:03 Daasin

I'd also like this as an option. On my Arch machine I usually install https://aur.archlinux.org/packages/proton-ge-custom-bin which only downloads the latest version (and overwriting previous versions) without requiring me to manually change the Proton build I want to use every time a Proton-GE update releases (since there's no version number attached to it). Having something similar on my Pop!_OS machine would be nice.

cobalt2727 avatar Oct 07 '22 16:10 cobalt2727

Is there any ETA on this PR getting merged into main?

Daasin avatar Oct 15 '22 15:10 Daasin

Thank you! This makes things much easier.

cobalt2727 avatar Oct 19 '23 03:10 cobalt2727