ATLauncher icon indicating copy to clipboard operation
ATLauncher copied to clipboard

Implement semantic versioning

Open Doomsdayrs opened this issue 2 years ago • 3 comments

Description of the Change

Implement semantic versioning.

Let this update proliferate before migrating over to semantic versioning.

Testing

Added test cases for the current state.

Related Issues

#555

Doomsdayrs avatar Dec 30 '22 04:12 Doomsdayrs

A thought on this, instead of making revision null, we can make it a magic number, like 99, that way we don't need to wait for people to update to this intermediary version and wait it out, we can treat a reserved value of 99 to mean null essentially, that way when we do to switch to full on semantic, even old clients will update since the reserved value ends up being set to 99 instead of null and having a panic.

RyanTheAllmighty avatar Jan 02 '23 12:01 RyanTheAllmighty

A thought on this, instead of making revision null, we can make it a magic number, like 99, that way we don't need to wait for people to update to this intermediary version and wait it out, we can treat a reserved value of 99 to mean null essentially, that way when we do to switch to full on semantic, even old clients will update since the reserved value ends up being set to 99 instead of null and having a panic.

Implemented~

Doomsdayrs avatar Apr 03 '23 21:04 Doomsdayrs

Just FYI I plan to push this out with the work on the new Edit Instance dialog (#556) roughly end of May. Closer to that time I'll be sure to test the heck out of this using my local test dev server, just to make sure both backend and frontend handles it fine

RyanTheAllmighty avatar Apr 29 '23 14:04 RyanTheAllmighty