pelita icon indicating copy to clipboard operation
pelita copied to clipboard

Show group numbers next to the group names during the tournament

Open nimpy opened this issue 3 years ago • 8 comments

As the group names are only revealed just before the tournament, it was hard to keep track of which group name corresponds to which group number, so having both information would have been useful.

nimpy avatar Sep 08 '21 12:09 nimpy

You mean during the tournament, to know which group you are currently cheering for? Or for your bots to have access to the group name?

lschwetlick avatar Sep 08 '21 12:09 lschwetlick

I meant the former, i.e. during the tournament (in the GUI and in the terminal where the information about the upcoming matches, stats, etc. is printed) -- basically wherever the group names are shown, I would have liked to see the group number too.

The reasoning for this: Throughout the course when I was talking to people, everyone was referring to their group by the group number (and secretive about the group name). However, during the tournament I could no longer associate the groups with their members because now the groups were referred to by their freshly-revealed names.

nimpy avatar Sep 08 '21 13:09 nimpy

If printing it just before a match (and possible thereafter, when announcing the winner) is enough, you can try to add it to this line https://github.com/ASPP/pelita/blob/1429024fca389691f260622fc539017703411d89/pelita/tournament/init.py#L482

We do not store the group number specifically in our yaml config (it looks like this: https://github.com/ASPP/pelita/blob/main/tournament.yaml but instead of pelita/player/StoppingPlayer it references the group0.py files), however, but we generate an id (which is just "#0", …, "#4" per default) in the Config class: https://github.com/ASPP/pelita/blob/1429024fca389691f260622fc539017703411d89/pelita/tournament/init.py#L235-L253

This id is what is passed around in the tournament file (as team1, team2 in the config.print example), so I guess, we can just also print the team1 variable itself in addition to the team name.

Debilski avatar Sep 08 '21 13:09 Debilski

Somewhat related to the wider problem of finding one’s group easily during the tournament: We could colourise (or at least add some sort of colour sprinkle) the bots differently from the classic red–blue scheme during the tournament (see #574).

Debilski avatar Sep 10 '21 09:09 Debilski

I think adding the group number in the GUI, so that the group name reads "Cool Name - N" where N is the group number is sufficient, straightforward and easy to implement, if we adjust the yml input data to also store the group number.

On Fri 10 Sep, 02:03 -0700, Rike-Benjamin Schuppner @.***> wrote:

Somewhat related to the wider problem of finding one’s group easily during the tournament: We could colourise (or at least add some sort of colour sprinkle) the bots differently from the classic red–blue scheme during the tournament (see #574¹).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub², or unsubscribe³. Triage notifications on the go with GitHub Mobile for iOS⁴ or Android⁵. ☘

––––

¹ https://github.com/ASPP/pelita/issues/574 ² https://github.com/ASPP/pelita/issues/737#issuecomment-916750232 ³ https://github.com/notifications/unsubscribe-auth/AACUYCY73GSMNWN6NLANOJTUBHCVDANCNFSM5DUUQTIQ ⁴ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 ⁵ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

otizonaizit avatar Sep 10 '21 13:09 otizonaizit

So, @nimpy, do you want to be helping us with this? :)

Debilski avatar Oct 12 '21 14:10 Debilski

Yes!! I should have time this weekend to work on it :)

nimpy avatar Oct 13 '21 06:10 nimpy

Perfect! :)

Debilski avatar Oct 13 '21 11:10 Debilski