askbot-devel icon indicating copy to clipboard operation
askbot-devel copied to clipboard

I think I improved the readme and simplify the docker

Open jrichardsz opened this issue 4 years ago • 4 comments

Today I tried to deploy askbot in heroku and/or openshift with no luck due to several problems:

  • There isn't a step by step readme with requirements and variables
  • Current Dockerfile in master does not allow me to parametrize if I have already a database, the database host , port , admin alias/mail, SECRET_KEY
  • If syncdb, migrate or collectstatic has an internal error, no log is displayed. So I stored them to /src/startup.log
  • I think readme.md is more more friendly than readme.rst
  • When I run the container, an error pointing me to use pytz<=2019.3 instead pytz<=2016.4
  • I added (and commented in .gitignore)init.py, manage.py , settings.py, urls.py to the root in order to start the server

Finally I was able to run a success docker container but with this changes. I didn't touch the core : https://github.com/software-architect-tools/askbot/pull/1

How can I adapt to your standards this PR in order to point to your official repository?

Thanks

jrichardsz avatar Jun 06 '20 05:06 jrichardsz

The issue is that I'm just in the progress of completing the askbot-setup script in the branch supporting python3. Once this script is done it would perhaps make more sense to improve the docker deployment process.

I haven't read your changes yet, will do that some time tomorrow, thank you for being willing to contribute.

evgenyfadeev avatar Jul 27 '20 02:07 evgenyfadeev

Thanks to you for your time.

jrichardsz avatar Jul 28 '20 16:07 jrichardsz

Looks great, thank you for sharing your code, this will be implemented after the askbot-setup is done.

evgenyfadeev avatar Jul 29 '20 13:07 evgenyfadeev

Your pull request is not available to me, so I cannot tell from which branch you tried to create a Docker image. The Askbot Python 3 branch, which is now this project's master branch used to contain Dockerfiles that would accept SECRET_KEY and DATABASE_URL as environment variables. Since there is no installer at the moment, I provided a more sophisticated Dockerfile as part of #867 . Maybe this addresses your problem.

martin-bts avatar Aug 23 '20 21:08 martin-bts