askbot-devel icon indicating copy to clipboard operation
askbot-devel copied to clipboard

Adding custom auth provider not working

Open Ptosiek opened this issue 7 years ago • 1 comments

Since commit https://github.com/ASKBOT/askbot-devel/pull/720/commits/68a2f8b546ddd9541efcafc3751c11efe41ba2a9, adding a custom provider is not working. In django_authopenis.utils 'providers' was replaced by an OrderectDict but add_custom_provider tries to insert the provider in the dict (line 381) providers.insert(mod.order_number - 1, mod.name, mod.as_dict()) Quick fix would be replacing with: providers[mod.name]= mod.as_dict() But the ability to specify the ordering is lost this way, not sure if needed though..

Ptosiek avatar Nov 02 '17 08:11 Ptosiek

This was fixed in the 0.11.x branch with https://github.com/ASKBOT/askbot-devel/commit/78cc354ed809d457a35b8082d3860995d10d00d8 and https://github.com/ASKBOT/askbot-devel/commit/2faccae0e750119fec6460b830a7669decd0fe13

martin-bts avatar Jul 21 '19 18:07 martin-bts