DAPLink icon indicating copy to clipboard operation
DAPLink copied to clipboard

add new hci stm32f072xx

Open zjli-2019 opened this issue 3 years ago • 2 comments

This based on PR https://github.com/ARMmbed/DAPLink/pull/805 and mbrossard/DAPLink:feature/stm32f072cb_hic, with following updates:

  1. updated with main branch;
  2. Generalized to support all stm32f072xx such as stm32f072cb and stm32f072c8, if flash size is large enough.

PS: Regarding the project generation of stm32f072c8, there is a PR https://github.com/project-generator/project_generator_definitions/pull/151.

zjli-2019 avatar Feb 25 '22 01:02 zjli-2019

stm32f0728_if , this naming is inconsistent with others like stm32f103xb_if. I suppose it should be stm32f072x8_if. Same for hic_stm32f072cb , module_hic_stm32f072cb , stm32f072cb.yaml , hic_stm32f072c8 and module_hic_stm32f072c8 .

~~File records/board/stm32f072b_disco.yaml seems to be missing.~~ Besides, in stm32f072b_disco_if , first part designates interface chip. hence I believe it will be stm32f103xb_stm32f072bdisco_if .

Edited: I found stm32f072b_disco.yaml here .

elfmimi avatar Apr 09 '22 08:04 elfmimi

Shouldn't https://github.com/mbrossard/DAPLink/blob/feature/stm32f072cb_hic/source/board/IO_Config_Override.h be located at source/board/override_stm32f072b_disco/IO_Config_Override.h ?

elfmimi avatar Apr 09 '22 09:04 elfmimi

Shouldn't https://github.com/mbrossard/DAPLink/blob/feature/stm32f072cb_hic/source/board/IO_Config_Override.h be located at source/board/override_stm32f072b_disco/IO_Config_Override.h ?

Nice catch.

mbrossard avatar Oct 01 '22 16:10 mbrossard

This based on PR #805 and mbrossard/DAPLink:feature/stm32f072cb_hic, with following updates:

  1. updated with main branch;

I just rebased mbrossard/DAPLink:feature/stm32f072cb_hic onto main. Squashing the commits make it harder to understand your changes.

  1. Generalized to support all stm32f072xx such as stm32f072cb and stm32f072c8, if flash size is large enough.

It seems your changes reduce the flash size to 64KB.

I have been looking at adding a STM32F103C8 target, and similarly to STM32F072CB vs STM32F072C8 it should not be a very invasive change.

mbrossard avatar Oct 01 '22 17:10 mbrossard

Replaced by #991

mbrossard avatar Dec 10 '22 04:12 mbrossard