DAPLink icon indicating copy to clipboard operation
DAPLink copied to clipboard

Change weak target family descriptors to references

Open flit opened this issue 5 years ago • 10 comments

This change replaces the default weak family descriptor structs (each taking up the full family descriptor size) in target_family.c with weak references. The purpose is to save .rodata space.

flit avatar Jan 13 '20 15:01 flit

/morph test

flit avatar Jan 13 '20 15:01 flit

Can you check test failures to proceed here?

0xc0170 avatar Feb 03 '20 17:02 0xc0170

/morph test

flit avatar Dec 12 '20 20:12 flit

/morph test

flit avatar Jan 03 '21 20:01 flit

/morph test

flit avatar Jan 03 '21 21:01 flit

/morph test

flit avatar Jan 03 '21 21:01 flit

/morph test

flit avatar Jan 04 '21 19:01 flit

/morph test

flit avatar Jan 11 '21 21:01 flit

/morph test

flit avatar Jan 12 '21 18:01 flit

I think this PR has gotten stale. A lot has been merged to develop, but changing

__attribute__((weak)) const target_family_descriptor_t g_xxxxx  = {0};

to

extern __WEAK const target_family_descriptor_t g_xxxx;

caused some issue with armcc so it was backed out (see [fb4b2292981671c6441d08eec8e51c3a685f4390]).

mathias-arm avatar Oct 14 '21 23:10 mathias-arm