acle icon indicating copy to clipboard operation
acle copied to clipboard

FP8 ACLE specification

Open momchil-velikov opened this issue 1 year ago • 8 comments


name: Pull request about: Technical issues, document format problems, bugs in scripts or feature proposal.


Thank you for submitting a pull request!

If this PR is about a bugfix:

Please use the bugfix label and make sure to go through the checklist below.

If this PR is about a proposal:

We are looking forward to evaluate your proposal, and if possible to make it part of the Arm C Language Extension (ACLE) specifications.

We would like to encourage you reading through the contribution guidelines, in particular the section on submitting a proposal.

Please use the proposal label.

As for any pull request, please make sure to go through the below checklist.

Checklist: (mark with X those which apply)

  • [ ] If an issue reporting the bug exists, I have mentioned it in the PR (do not bother creating the issue if all you want to do is fixing the bug yourself).
  • [x] I have added/updated the SPDX-FileCopyrightText lines on top of any file I have edited. Format is SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}> (Please update existing copyright lines if applicable. You can specify year ranges with hyphen , as in 2017-2019, and use commas to separate gaps, as in 2018-2020, 2022).
  • [x] I have updated the Copyright section of the sources of the specification I have edited (this will show up in the text rendered in the PDF and other output format supported). The format is the same described in the previous item.
  • [ ] I have run the CI scripts (if applicable, as they might be tricky to set up on non-*nix machines). The sequence can be found in the contribution guidelines. Don't worry if you cannot run these scripts on your machine, your patch will be automatically checked in the Actions of the pull request.
  • [x] I have added an item that describes the changes I have introduced in this PR in the section Changes for next release of the section Change Control/Document history of the document. Create Changes for next release if it does not exist. Notice that changes that are not modifying the content and rendering of the specifications (both HTML and PDF) do not need to be listed.
  • [x] When modifying content and/or its rendering, I have checked the correctness of the result in the PDF output (please refer to the instructions on how to build the PDFs locally).
  • [x] The variable draftversion is set to true in the YAML header of the sources of the specifications I have modified.
  • [ ] Please DO NOT add my GitHub profile to the list of contributors in the README page of the project.

momchil-velikov avatar Jun 13 '24 16:06 momchil-velikov

I'd prefer slightly different naming for the intrinsics and new types. Specifically:

  1. Can we call the new types floatm8_t, floatm8x16_t, svfloatm8_t, etc.? This would be more consistent with existing type names while still preserving the "modal" distinction. It also makes the type name more easily distinguishable from FPMR values (which use fpm_t).

  2. Can we drop the _fpm suffix from all the intrinsic names, and instead represent the modality in the type suffix (by replacing _f8 with _fm8 wherever it appears)?

Combining these, my proposal is to replace, for example, float16x4_t vdot_lane_f16_f8_fpm(float16x4_t vd, fpm8x8_t vn, fpm8x8_t vm, __builtin_constant_p(lane), fpm_t fpm) with float16x4_t vdot_lane_f16_fm8(float16x4_t vd, floatm8x8_t vn, floatm8x8_t vm, __builtin_constant_p(lane), fpm_t fpm).

alicecarlotti avatar Jun 19 '24 11:06 alicecarlotti

  1. Can we call the new types floatm8_t, floatm8x16_t, svfloatm8_t, etc.?
  2. Can we drop the _fpm suffix from all the intrinsic names, and instead represent the modality in the type suffix (by replacing _f8 with _fm8 wherever it appears)?

I am in favour of both proposals.

momchil-velikov avatar Jun 21 '24 10:06 momchil-velikov

This might have been mentioned already, but the new vector types should also be added to svset_neonq, svget_neonq and svdup_neonq.

rsandifo-arm avatar Jun 28 '24 08:06 rsandifo-arm

  1. Can we call the new types floatm8_t, floatm8x16_t, svfloatm8_t, etc.?
  2. Can we drop the _fpm suffix from all the intrinsic names, and instead represent the modality in the type suffix (by replacing _f8 with _fm8 wherever it appears)?

I am in favour of both proposals.

Coming up Soon(tm).

momchil-velikov avatar Jul 05 '24 15:07 momchil-velikov

This might have been mentioned already, but the new vector types should also be added to svset_neonq, svget_neonq and svdup_neonq.

My next step is to add intrinsics for the untyped SVE/SME instructions, that would include these too.

momchil-velikov avatar Jul 05 '24 15:07 momchil-velikov

I'd prefer slightly different naming for the intrinsics and new types. Specifically:

  1. Can we call the new types floatm8_t, floatm8x16_t, svfloatm8_t, etc.? This would be more consistent with existing type names while still preserving the "modal" distinction. It also makes the type name more easily distinguishable from FPMR values (which use fpm_t).

This part done.

momchil-velikov avatar Jul 23 '24 17:07 momchil-velikov

  1. Can we call the new types floatm8_t, floatm8x16_t, svfloatm8_t, etc.? This would be more consistent with existing type names while still preserving the "modal" distinction. It also makes the type name more easily distinguishable from FPMR values (which use fpm_t).

As an amendment that follows the scheme used when going from float16 -> bfloat16 what about mfloat8_t, mfloat8x16_t, svmfloat8_t with "m" meaning "modal"?

paulwalker-arm avatar Jul 26 '24 11:07 paulwalker-arm

Things renamed according to the above naming scheme.

momchil-velikov avatar Jul 30 '24 11:07 momchil-velikov

Squished everything and rebased, not supposed to contain content changes.

momchil-velikov avatar Sep 12 '24 14:09 momchil-velikov

Last update was completely botched, now fixed.

momchil-velikov avatar Sep 18 '24 12:09 momchil-velikov