abi-aa icon indicating copy to clipboard operation
abi-aa copied to clipboard

[PAUTHABIELF64] Possible typo in `R_AARCH64_AUTH_GOT_LO12_NC`

Open kovdan01 opened this issue 3 months ago • 3 comments

In https://github.com/ARM-software/abi-aa/blob/main/pauthabielf64/pauthabielf64.rst#auth-variant-got-generating-relocations, AUTH variants of GOT-generating relocations are defined. Their names are in most cases basically the same as corresponding non-AUTH relocs names, but for R_AARCH64_AUTH_GOT_LO12_NC, it's not true: the non-AUTH variant contains LD64 (R_<CLS>_LD64_GOT_LO12_NC), so the AUTH variant should probably be R_AARCH64_AUTH_LD64_GOT_LO12_NC. If LD64 is considered redundant since we don't have 32-bit versions of AUTH relocations, it should be probably deleted from other AUTH relocs names: in R_AARCH64_AUTH_LD64_GOTOFF_LO15 and R_AARCH64_AUTH_LD64_GOTPAGE_LO15, LD64 is present.

Is LD64 omitted in R_AARCH64_AUTH_GOT_LO12_NC intentionally? If yes, it would be nice if you explain rationale of such decision.

kovdan01 avatar Mar 25 '24 11:03 kovdan01