ComputeLibrary icon indicating copy to clipboard operation
ComputeLibrary copied to clipboard

CMake lacks `install` target

Open BwL1289 opened this issue 1 year ago • 11 comments

Platform: Aarch64 Linux

Problem description: When trying to compile from source using CMake and Ninja, I see the following error:

30.90 ninja: error: unknown target 'install'

It seems CMake lacks an install target.

Have tried manually installing libs, its symlinks, and headers automatically but to no avail.

Here's an example of how AWS implemented this for their C SDK.

This is likely an extension of #1048.

BwL1289 avatar Aug 05 '24 17:08 BwL1289

@morgolock any chance to make this a priority?

BwL1289 avatar Aug 12 '24 14:08 BwL1289

Hi @BwL1289

Thanks for raising this, I'll discuss it with the team.

morgolock avatar Aug 12 '24 14:08 morgolock

Thank you.

BwL1289 avatar Aug 12 '24 14:08 BwL1289

Hi @morgolock. Not trying to be a bother. Please let me know if the team thought this was worth prioritizing. Thank you!

BwL1289 avatar Aug 15 '24 14:08 BwL1289

Hi @BwL1289

Yes we will do it, I will ask for this to be in the next release. Once I get confirmation I will let you know.

morgolock avatar Aug 17 '24 06:08 morgolock

Thanks @morgolock.

BwL1289 avatar Aug 17 '24 14:08 BwL1289

Hi @BwL1289

It's likely we will start working on this in a couple of weeks.

Hope this helps.

morgolock avatar Sep 06 '24 08:09 morgolock

@morgolock yes that helps. Thank you.

BwL1289 avatar Sep 06 '24 13:09 BwL1289

@morgolock do you have an updated timeline? Thank you.

BwL1289 avatar Sep 27 '24 21:09 BwL1289

Hi @BwL1289

We are currently discussing it, once we have a good idea of the effort I will give you an update. I'll know more in the coming days.

Hope this helps

morgolock avatar Oct 08 '24 09:10 morgolock

Thanks.

BwL1289 avatar Oct 08 '24 12:10 BwL1289

@morgolock following up again. Can you please let me know if the team plans to fix this?

BwL1289 avatar Oct 30 '24 15:10 BwL1289

Hi @BwL1289

The following patch will solve the problem. This fix will be present in v24.11

Hope this helps

morgolock avatar Nov 04 '24 09:11 morgolock

@morgolock thank you.

BwL1289 avatar Nov 04 '24 14:11 BwL1289

@morgolock please reopen this issue. It looks like you guys forgot to merge the patch into 24.11: https://github.com/ARM-software/ComputeLibrary/blob/v24.11/CMakeLists.txt#L335. The patch you mentioned is not present.

BwL1289 avatar Nov 25 '24 20:11 BwL1289

FWIW, I forked this repo and implemented the change manually. I can confirm it works. I opened a PR: https://github.com/ARM-software/ComputeLibrary/pull/1151

BwL1289 avatar Nov 26 '24 02:11 BwL1289

Hi @BwL1289

Apologies for the confusion, I've reopened the issue.

We cannot merge the PR on github unfortunately, we only publish a snapshot of the main dev repo on github and if we merge a PR it will go out of sync with the release branch in the dev repo.

Apologies for the confusion. This patch will be present in our next release 24.11.1.

morgolock avatar Nov 26 '24 10:11 morgolock

Hi @BwL1289

The patch has been included in v24.11.1, please let us know if this solves your problem.

Hope this helps

morgolock avatar Dec 02 '24 17:12 morgolock