CMSIS_6 icon indicating copy to clipboard operation
CMSIS_6 copied to clipboard

core_ca.h defines for ISR and SGIR_INTID

Open NVMarkovich opened this issue 11 months ago • 4 comments

  1. In core_ca.h, lines 644; 647; 650, the ISR_A_Pos, ISR_I_Pos, ISR_F_Pos should be not 13U, 12U, 11U, but 8U, 7U, 6U respectively, as per structure at lines 636-638.
  2. In the same file, line 921, GICDistributor_SGIR_INTID_Msk should be not 0x7U, but 0xFU, as the INTID is 4 bits.
  3. GICInterface_HPPIR_INTID_Msk should be 0x3FFU instead of 0xFFFFFFU.

NVMarkovich avatar Jan 24 '25 12:01 NVMarkovich

@NVMarkovich, thanks for raising this. Would you mind to raise a pull-request contributing the requested changes?

JonatanAntoni avatar Jan 24 '25 13:01 JonatanAntoni

Hello, I am a bit new at GitHub, and I thought it will be enough to raise the question and the colleagues from ARM will correct their file.


From: Jonatan Antoni @.> Sent: Friday, 24 January 2025 15:44 To: ARM-software/CMSIS_6 @.> Cc: Nikolay Markovich @.>; Mention @.> Subject: Re: [ARM-software/CMSIS_6] core_ca.h defines for ISR and SGIR_INTID (Issue #215)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Never provide your password! VORSICHT: Diese E-Mail kommt von einem externen Absender. Bitte keine Links anklicken oder Anlagen öffnen falls Sie den Absender nicht kennen. Niemals Ihr Kennwort eingeben!

@NVMarkovichhttps://github.com/NVMarkovich, thanks for raising this. Would you mind to raise a pull-request contributing the requested changes?

— Reply to this email directly, view it on GitHubhttps://github.com/ARM-software/CMSIS_6/issues/215#issuecomment-2612563191, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BOZ3ATGKMS3DNLJNQBOSYBD2MI7SXAVCNFSM6AAAAABVZTZ45KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJSGU3DGMJZGE. You are receiving this because you were mentioned.

Hilscher Development & Test Center EOOD | Business Park Varna - B8, 402 | 9009 Varna | Bulgaria | www.hilscher.comhttp://www.hilscher.com/

Important Information: This e-mail message including its attachments contains confidential and legally protected information solely intended for the addressee. If you are not the intended addressee of this message, please contact the addresser immediately and delete this message including its attachments. The unauthorized dissemination, copying and change of this e-mail are strictly forbidden. The addresser shall not be liable for the content of such changed e-mails.

????????: ???? ?????????? ????????? ? ??????????? ??? ???? ??????? ???????? ?????????? ????????????? ?????????? ?? ???????? ????? ??????????. ??? ?????? ????? ?? ? ? ??????? ?? ?????????? ???? ????????? ?? ???????? ???? ????????? ? ??????????? ??? ???? ??????? ???? ???????????? ????????? ????????. ????????, ??????? ??? ????????? ? ????? ???? ?? ???????????? ??????????? ? ???? ????????? ??? ????????? ???????? ?? ?????? ? ?????? ?????????.

NVMarkovich avatar Jan 24 '25 13:01 NVMarkovich

@NVMarkovich, the files you are referring to are community contributed.

JonatanAntoni avatar Jan 24 '25 14:01 JonatanAntoni

ok, when I finish reviewing the whole file, I will consider raising a pull-request. Meanwhile I plan to add the further new-found issues in the initial message, if You don't mind.

NVMarkovich avatar Jan 24 '25 14:01 NVMarkovich