AR.js icon indicating copy to clipboard operation
AR.js copied to clipboard

Cable centered position of content in NFT inside AR.js core

Open nicolocarpignoli opened this issue 4 years ago • 11 comments

Content is placed at 0,0 position. Can be useful if it's present at the center of the marker. We have to understand if this has to be fixed on jsartoolkit5 side (better) or on AR.js core.

nicolocarpignoli avatar Feb 29 '20 18:02 nicolocarpignoli

In my opinion, this should be done inside jsartoolkit5, possibly as an option. Anyway, not to be implemented directly on AR.js

nicolocarpignoli avatar Feb 29 '20 18:02 nicolocarpignoli

For video setting the position to the centre of the marker is really useful.

JamesBotterill avatar Mar 13 '20 16:03 JamesBotterill

For video setting the position to the centre of the marker is really useful.

@JamesBotterill I think that will be useful also for placing other model types. I have a branch and there is also a PR https://github.com/kalwalt/jsartoolkit5/pull/42 on my jsartoolkit5 repository where we are trying to achieve this. I think after the v 3.0.0 release we'll come back on this.

kalwalt avatar Mar 13 '20 17:03 kalwalt

There are some news on this side: with the latest commit https://github.com/kalwalt/jsartoolkit5/pull/42/commits/86a19807000d9452ff537f8aa97775629c60d418 in my PR https://github.com/kalwalt/jsartoolkit5/pull/42 it's easier to reposition the model in the center of the marker. Tests are welcome!

kalwalt avatar Mar 25 '20 15:03 kalwalt

Any news on this one, yet, @kalwalt? Unfortunately, it's not really usable for production in this condition. Thank you very much for your work! :)

93Dennis avatar Jul 01 '20 11:07 93Dennis

@93Dennis i have no any news, sincerely i have no time to dedicate. My actual job do not let me so much free time ..

kalwalt avatar Jul 02 '20 21:07 kalwalt

I have seen this same behavior using the NFT three.js sample. I added a red sphere to 0,0,0 and it shows up in different places depending upon the resolution and orientation of the phone (landscape vs. portrait). Is this really a duplicate of #109?This one seems to be more about making 0,0,0 be the center of the marker, which I agree would be convenient. However, #109 is about making the 0,0,0 coordinate be consistent, even if it is the lower left (which it is now). I suppose one wouldn't be possible without the other, but consistency of placement seems more important than where the origin is placed.

Attached some images I took on my Galaxy Tab S6 + Chrome + Android 10 at 640x480 and 480x640, in both portrait and landscape. 480x640 Landscape GalaxyTabS6 Chrome83 0 4103 106 Android10 480x640 Portrait GalaxyTabS6 Chrome83 0 4103 106 Android10 640x480 Portrait GalaxyTabS6 Chrome83 0 4103 106 Android10 640x480 Landscape GalaxyTabS6 Chrome83 0 4103 106 Android10

patrickoshaughnessey avatar Jul 07 '20 21:07 patrickoshaughnessey

Hello, Thank you for the amazing work on AR,js!

Are there any updates regarding this issue? We would like to use AR.js as our WebAR solution, but this issue is making it hard to release to production.

Best.

Dryra avatar Aug 10 '20 15:08 Dryra

I have the same problem and I partially solved it by adjusting the position and rotation of the video, is there a solution currently? by the way, I also have a bigger problem, the NFT image recognition system works with the trex image in the example, but when I change this image to a custom one it doesn't work and the application gets stuck on the message of "loading, for please wait "and he never moves from here. Any ideas how to fix it?

PedroNan avatar Feb 26 '21 16:02 PedroNan

@PedroNan I was having same problem as you

problem

stuck at loading screen

why its happning?

It happening because of wrong path/url in src of nft tag or wrong path/url in your 3d file/img/video

or

you may have missed / forgot to get your .iset and .ifset and host them

or

you may have forget to add arjs proxy (for cors related issue).

RBOSAMIYA9 avatar Sep 29 '21 18:09 RBOSAMIYA9

Hello hello,

Any update on this ?

I'm trying to play video with a NFT image, all working great but the positioning of the video. I tried to give dev branch a shot but I get this : Error in loading marker on Worker TypeError: Q.getNFTData is not a function

Thanks !

Djek177 avatar Nov 25 '22 13:11 Djek177