AR.js icon indicating copy to clipboard operation
AR.js copied to clipboard

Dev

Open AnaCarolinaChaves opened this issue 4 years ago • 3 comments

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce? It removes the first prompt that appears on Safari that asks to tap the screen

Can it be referenced to an Issue? If so what is the issue # ? No issue, just something that was seen while testing

How can we test it? If, for instance, you run the aframe-ar on an apple device using Safari the prompt should now be different.

Summary When using Safari, before asking to grant camera permissions an alert would appear asking to tap the screen to grant geolocation permissions.

Does this PR introduce a breaking change?

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser It should be used an iOS 13+ device with Safari

Other information

AnaCarolinaChaves avatar May 13 '21 21:05 AnaCarolinaChaves

Hi @AnaCarolinaChaves thanks for this. I do not have access to a Mac so unfortunately cannot test... @nicolocarpignoli @kalwalt do you have access to Mac?

nickw1 avatar May 14 '21 12:05 nickw1

... Mac or iPhone (i.e. device with Safari)

nickw1 avatar May 14 '21 12:05 nickw1

No i haven't, can't test this

kalwalt avatar May 14 '21 13:05 kalwalt