AR.js icon indicating copy to clipboard operation
AR.js copied to clipboard

After using ES6 version, the effect is abnormal!

Open pxim opened this issue 5 years ago • 8 comments

Do you want to request a feature or report a bug?

DEMO https://codesandbox.io/s/bitter-night-i33kr?file=/src/ARView/index.tsx

xm.html normal 微信图片_20210319151011

index.html abnormal 2

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce.

Please mention other relevant information such as the browser version, Operating System and Device Name package.json

{ "name": "ar-three-cra", "version": "0.1.0", "private": true, "homepage": ".", "dependencies": { "@testing-library/jest-dom": "^5.11.4", "@testing-library/react": "^11.1.0", "@testing-library/user-event": "^12.1.10", "@types/jest": "^26.0.20", "@types/node": "^14.14.33", "@types/react": "^17.0.3", "@types/react-dom": "^17.0.2", "artoolkit5-js": "0.0.4", "devlibx": "0.0.19", "jsartoolkit": "0.0.0", "react": "^17.0.1", "react-dom": "^17.0.1", "react-helmet": "^6.1.0", "react-scripts": "4.0.3", "three": "^0.126.1", "threejsx": "0.0.2", "typescript": "^4.2.3", "web-vitals": "^1.0.1" }, "scripts": { "start": "react-scripts start", "build": "react-scripts build", "start-rewired": "react-app-rewired start", "build-rewired": "react-app-rewired build", "test": "react-scripts test", "eject": "react-scripts eject" }, "eslintConfig": { "extends": [ "react-app", "react-app/jest" ] }, "browserslist": { "production": [ ">0.2%", "not dead", "not op_mini all" ], "development": [ "last 1 chrome version", "last 1 firefox version", "last 1 safari version" ] }, "devDependencies": { "@types/react-helmet": "^6.1.0", "@types/three": "^0.126.0", "react-app-rewired": "^2.1.8" } }

What is the expected behavior?

If this is a feature request, what is motivation or use case for changing the behavior?

pxim avatar Mar 25 '21 02:03 pxim

Hi @pxim , Please note that the ES6-build is still in development. You can follow progress in #116 . This report could be helpful however in identifying remaining bugs. Could you specify (by means of a persistent github link) which exact file you used as the source for the AR.js-library? In case you listed AR.js as a dependency in your package.json, could you post an excerpt of that part of the package.json here? Thanks :-)

MikiDi avatar Mar 25 '21 07:03 MikiDi

Hi @pxim , Please note that the ES6-build is still in development. You can follow progress in #116 . This report could be helpful however in identifying remaining bugs. Could you specify (by means of a persistent github link) which exact file you used as the source for the AR.js-library? In case you listed AR.js as a dependency in your package.json, could you post an excerpt of that part of the package.json here? Thanks :-)

this is the demo https://codesandbox.io/s/bitter-night-i33kr?file=/src/ARView/index.tsx

this is pattern pattern-xiaoxiongmao

pxim avatar Mar 25 '21 09:03 pxim

Hi @pxim as said by @MikiDi the ES6 version is still in development. Probably won't works as expected, we are in a phase in which we have to rearrange the code and make decisions on how to restyle it , and consquently bugs will be solved in another step. We would activate a Arr.js NPM package as soon as the code will be more stable. If you are interested we will provide more informations in the PR. Thanks for testing!

kalwalt avatar Mar 25 '21 17:03 kalwalt

Hi @pxim as said by @MikiDi the ES6 version is still in development. Probably won't works as expected, we are in a phase in which we have to rearrange the code and make decisions on how to restyle it , and consquently bugs will be solved in another step. We would activate a Arr.js NPM package as soon as the code will be more stable. If you are interested we will provide more informations in the PR. Thanks for testing!

Well, then I can only wait, look forward to it. thanks.

pxim avatar Mar 26 '21 01:03 pxim

@pixim try this example https://github.com/kalwalt/react-AR-experiments/tree/master/react-threex-example with THREEx inside the project you need to run:

yarn
yarn start

kalwalt avatar Mar 28 '21 15:03 kalwalt

@pxim The ES6 branch is merged in the dev branch, can you test please?

kalwalt avatar Nov 16 '21 12:11 kalwalt

Hi, tested with 3.3.3-es6-beta-01 and 3.3.3-es6-beta-02, this error still occurs on mobiles. You can test with https://codesandbox.io/s/jolly-hodgkin-ssu33

j-era avatar Jan 10 '22 15:01 j-era

Hi, tested with 3.3.3-es6-beta-01 and 3.3.3-es6-beta-02, this error still occurs on mobiles. You can test with https://codesandbox.io/s/jolly-hodgkin-ssu33

I tested your codesandbox, but can't track the hiro pattern. I will try again when i have time or i will create another example for testing. I haven't had the time to continue on AR.js.

kalwalt avatar Jan 11 '22 22:01 kalwalt