APYDataGridBundle icon indicating copy to clipboard operation
APYDataGridBundle copied to clipboard

Published 20 hours ago • verified publisher icon APY

Test improvement

Open DonCallisto opened this issue 8 years ago • 3 comments

Hello everybody, in order to fulfill point 5 of https://github.com/APY/APYDataGridBundle/pull/877#issuecomment-267813654 I've started a brand new branch (from symfony3 one) that will contain all commits for missing tests.

You are welcome if you want to collaborate as I'm not a master of PHPUnit and as I'm pretty new to this project.

Moreover it will be useful a list of non tested classes in order to check them while we do this task.

DonCallisto avatar Dec 20 '16 22:12 DonCallisto

@hmert maybe is better a PR with a WIP status in order to keep track of current files and commits? What do you think?

DonCallisto avatar Dec 20 '16 22:12 DonCallisto

@DonCallisto Test improvement looks good for me. And do you merge that new test branch into symfony3 branch?

hmert avatar Dec 24 '16 12:12 hmert

@hmert yes, the plain is this as from that moment we could also do some refactor. However I suppose I'm gonna need some help for "core" files; now I'm on more "peripheral" ones

DonCallisto avatar Dec 24 '16 12:12 DonCallisto