react-native-button icon indicating copy to clipboard operation
react-native-button copied to clipboard

Published 20 hours ago • verified publisher icon APSL

fix Button.js: put an undefined-check for TouchableNativeFeedback

Open ngduc opened this issue 7 years ago • 3 comments

Context: I'm using "react-native-web" & "react-native-gifted-form" which has "APSL/react-native-button" as a dependency. I think because in web mode, TouchableNativeFeedback is undefined, it crashed my app.

I just added an undefined-check for TouchableNativeFeedback. Please merge. Thanks.

image

ngduc avatar Dec 03 '16 01:12 ngduc

@alvaromb: could you merge this minor commit? Thanks.

ngduc avatar Dec 06 '16 23:12 ngduc

Hi @ngduc!

Please be patient, I want to check why the tests are failing.

Thanks.

alvaromb avatar Dec 07 '16 08:12 alvaromb

@alvaromb The failed tests may be related to this - https://github.com/facebook/jest/issues/1840

Have you tried this?

This was due react@^15.3.2 resolve to [email protected] due how npm semver works. Setting the react version to react@~15.3.2 solved the issue

ngduc avatar Dec 09 '16 20:12 ngduc