puput
puput copied to clipboard
APSL
Adds support up to Wagtail 5.2
@leewesleyv
Hi! Wagtail 5.2 supports Django 4.2.x and 5.0.x.
Is there a reason for 'Django>=3.2,<4.3' requirement?
@itbabu I was thinking of removing the Django dependency in its entirety, but wasn't sure if that would be the best way forward. The main aim here was to support both Wagtail LTS (5.2) and Django LTS (4.2), where Django was already supported. Hence why I only bumped Wagtail. I'd love to hear what you would recommend in terms of supported versions.
@leewesleyv
Looking into the Wagtail Release schedule (https://github.com/wagtail/wagtail/wiki/Release-schedule), I see that:
Wagtail 5.2 LTS is supported until 3 February 2025. Wagtail 5.1 is supported until 1 February 2024. Therefore, it makes sense to support only Wagtail 5.2 and above.
Inspecting the Wagtail setup (https://github.com/wagtail/wagtail/blob/main/setup.py), I found that it requires:
install_requires = [
"Django>=4.2,<6.0",
...
]
Puput should support this range or a subset of it. Django 3.2 falls outside of this range, so it shouldn't be supported.
Consequently, I would remove the Django requirement from Puput setup and keep only the Wagtail requirement. The testing configurations would be:
- Django: 4.2, 5.0 (reference: https://www.djangoproject.com/download/)
- Wagtail: 5.2
- Python for Django 4.2 : 3.8, 3.9, 3.10, 3.11, 3.12 (reference: https://docs.djangoproject.com/en/5.0/faq/install/)
- Python for Django 5.0: 3.10, 3.11, 3.12 (reference: https://docs.djangoproject.com/en/5.0/faq/install/)
@leewesleyv
You can add the changes from this fork to this PR:
https://github.com/itbabu/puput/tree/feature/wagtail-52-support.
Additionally, the other requirements should be addressed: django-el-pagination: Starting from version 4.1.0, they added support for Django 5.0 and Python 3.12 (not yet on Pypi). django-taggit and wagtail-markdown: These should be compatible and work as expected. django-social-share and django-colorful I would remove these packages entirely from the project, as they are outdated.
What are your thoughts?
@itbabu Especially to what extend django-social-share and django-colorful are used, I think it would be a good decision to remove these dependencies. I will see if I can find a fitting replacement (code-wise) for where we use these, or have a clear migration path for people that are using these functionalities.
Hello @leewesleyv! Sorry for not paying attention to this... I'm planing to work on it this week, I'm currently testing the PR. Do you mind to update the branch is order that is good to merge, please?
As the conflic it was because of me merging a dependabot PR, I've solved. So, lets merge. Thanks again for your work @leewesleyv and @itbabu :100: