puput icon indicating copy to clipboard operation
puput copied to clipboard

Django Comments are now required

Open loleg opened this issue 4 years ago • 3 comments

Currently the setup guide or comments chapter makes no mention of Django Comments - but I am getting this error from compress:

../lib/python3.7/site-packages/puput/templates/puput/comments/django_comments.html: 
'comments' is not a registered tag library

Adding it to my project (django.contrib.sites and django_comments in INSTALLED_APPS) according to the Quick Start resolves this.

loleg avatar May 16 '20 16:05 loleg

Adding django.contrib.sites breaks things (like the admin panel, ahem..) in Wagtail, so this is not a good workaround. If anyone has other ideas of how to deal with this error, please let me know.

loleg avatar May 18 '20 15:05 loleg

I've added an option to use django comments in #215, the documentation was updated in that PR as well, so it looks like it needs to be pushed to readthedocs? Anyway, I'll check out the error

michalpleszczynski avatar Sep 01 '20 11:09 michalpleszczynski

I would use the documentation of django-comments-xtd instead of django-comments if I were you. I Followed all the steps in the django-comments-xtd quick start guide (https://django-comments-xtd.readthedocs.io/en/latest/quickstart.html), added PUPUT_COMMENTS_PROVIDER = "puput.comments.DjangoCommentsProvider" in the Django Settings and got comments to work.

When I change django_comments.html like below, nested indenting doesn't work unfortunately. If anyone could help me with that it would be greatly appreciated.

{% load comments %}
{% load comments_xtd %}

<div>
    <h3>Comments:</h3>
    {% render_comment_form for entry %}
    {% render_xtdcomment_tree for entry%}
</div>

woesoe avatar Apr 11 '21 12:04 woesoe