openapi-directory icon indicating copy to clipboard operation
openapi-directory copied to clipboard

Fix apis.guru openapi 3.0 yaml

Open Jolanrensen opened this issue 3 years ago • 4 comments

Your own openapi spec appears out of date: ApiVersion.updated seems to be non required anymore. Metrics is missing almost all attributes while having additionalProperties: false

Jolanrensen avatar Nov 09 '22 12:11 Jolanrensen

Well that's embarrassing! Thanks for pointing these issues out. I've temporarily changed Metrics to allow additionalProperties and hopefully fixed the missing ApiVersion.updated dates (won't show up in the API until tomorrow).

MikeRalphson avatar Feb 17 '23 16:02 MikeRalphson

@MikeRalphson it also appears that you make ApiVersion.info a required property with minProperties: 1, but it's sometimes not supplied (for instance for "azure.com:azsadmin-quotas"). Removing it from the required: tag solves it.

Jolanrensen avatar Feb 28 '23 13:02 Jolanrensen

Thanks. This is related to #542 - I'd like to keep the API definition as-is and work on fixing the incorrect data, but is it causing you a downstream problem?

MikeRalphson avatar Feb 28 '23 14:02 MikeRalphson

Yes, it breaks in the OpenApi support of Kotlin Dataframe, since it tries to read the info object, which is required according to the spec, and it isn't present. But most likely, this implementation isn't the only thing that would break if received data isn't up to spec.

The specific bug happens at: azure.com:azsadmin-quotas, azure.com:sql-databaseSecurityAlertPolicies, azure.com:sql-serverAzureADAdministrators

Jolanrensen avatar Feb 28 '23 14:02 Jolanrensen