swagger-express-middleware
swagger-express-middleware copied to clipboard
APIDevTools
Add current Node.js versions to Travis CI config
Current LTS and stable versions of Node.js are missing from Travis CI build.
Interestingly, the newer Node.js versions seem to come up with a different size for the test PDF file. 0.10 to 0.12 return a size of 258441 while 4.2 and 5.4 agree on 258529. Checking the file size locally leads to yet a different result:
$ du --bytes tests/files/File.pdf
263287 tests/files/File.pdf
Do you have any idea what happens here?
I've just seen that the Content-Length matches for all versions and is equal to the result of du. But why does it differ from res.text.length?
Shit. I just realized that I have some un-pushed commits from back in October. This is one of them:
Well, that could "fix" it. :wink: (still... what happens with these control characters is beyond my understanding...)
If you don't mind sharing the commit, that would be awesome :sparkles:
Actually... can you go ahead and make that change yourself? I'm going to back-out the commits I made, because it also includes breaking changes that I really should have done on a branch instead.
superagent adds the Content-Length header automagically, so it needs to be removed when testing for its absence. I'm not sure how this test could not fail earlier... :wink:
Sorry for the radio silence. The past several days have been super busy for me, and I haven't even been able to get online much. I should be able to take a look at all your work in the next few days and get it merged in
@BigstickCarpet: no worries, I know there are still people left who have a live :grinning:
Hi @BigstickCarpet - I'm using Node 8 and would be interested in using this project, if we can be confident that Node 8 is supported, and the project itself builds in CI (seems to fail currently), etc. Is the project still being maintained and will pull requests such as this one eventually be merged? Many thanks.
