json-schema-ref-parser icon indicating copy to clipboard operation
json-schema-ref-parser copied to clipboard

Published 20 hours ago • verified publisher icon APIDevTools

Convert relative refs when resolving an external schema

Open karlvr opened this issue 4 years ago • 1 comments

Possibly corrects #200.

This however causes tests to fail as they’re not expecting the references to be resolved. I’m not sure yet how to fix the tests. I thought I’d wait to see if the fix is valid!

I'd love some feedback on this to progress it or change it!

karlvr avatar Mar 11 '21 22:03 karlvr

@karlvr hey I've poked a few people about trying to get a review, and hopefully it'll be more successful than when I tried 14 months ago.

philsturgeon avatar Jun 16 '22 14:06 philsturgeon

Bump

mikethecalamity avatar Oct 13 '22 20:10 mikethecalamity

Any update on this? We'd be happy to look at the tests and change them if needed but are not maintainers on the project.

Borduhh avatar Oct 18 '22 12:10 Borduhh

Hi there,

can someone help to write tests for this feature?

I've tested with npm run coverage:node @karlvr branch, and the tests are not passing, is that right? Please, correct with I'm wrong.

There is a starting point for the tests here: https://github.com/APIDevTools/json-schema-ref-parser/commit/e1217174563c57cd81bc06259cf665606295ebf9

(I've added a branch with changes from this PR on top of some changes done for ISSUE-283 for tests on Windows.)

danielfcollier avatar Oct 27 '22 21:10 danielfcollier

We'd need the conflicts fixed, but seems like nobody is around to review this other than me. Gulp.

philsturgeon avatar Dec 11 '22 14:12 philsturgeon

Bump? (I guess it's that time of year)

mikethecalamity avatar Sep 17 '23 02:09 mikethecalamity

@jonluca tagging you I’m if you’ve got time to have a look here. I’m not involved anymore.

philsturgeon avatar Sep 18 '23 09:09 philsturgeon

I'm open to a PR here but would need to update it to pass the tests and to use the new typescript repo. Closing this for now, feel free to open a new one

jonluca avatar Sep 18 '23 22:09 jonluca

Where's the new repo?

mikethecalamity avatar Sep 19 '23 02:09 mikethecalamity

It's this repo - all the code was migrated to TS ~8 months ago

jonluca avatar Sep 19 '23 02:09 jonluca

So I put the updates into a new PR: https://github.com/APIDevTools/json-schema-ref-parser/pull/322

But I have no idea if it's right, I've never used typescript before.

mikethecalamity avatar Sep 19 '23 04:09 mikethecalamity