Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Feature/watertagged

Open Intybyte opened this issue 1 year ago • 2 comments

Describe in detail what your pull request accomplishes

Add a validator for waterlogged blocks and a relative tag

Related issues:

  • Fixes #519

Checklist

  • [ ] Tested

Intybyte avatar Aug 26 '24 07:08 Intybyte

Please see @TylerS1066's comment on that issue

Upon some further discussion, I think it's best if we add a separate craft flag for maximum water (or possibly maximum liquid) rather than add an edge case that interprets waterlogged as water.

The issue is about limiting overall liquids not just waterlogging.

oh-noey avatar Aug 30 '24 16:08 oh-noey

Please see @TylerS1066's comment on that issue

Upon some further discussion, I think it's best if we add a separate craft flag for maximum water (or possibly maximum liquid) rather than add an edge case that interprets waterlogged as water.

The issue is about limiting overall liquids not just waterlogging.

So I just need to adda check for liquids too and I should be done right?

Intybyte avatar Aug 30 '24 16:08 Intybyte