Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Issue on PlayerListener class

Open SecretX33 opened this issue 1 year ago • 1 comments

I'm almost sure this line is wrong:

https://github.com/APDevTeam/Movecraft/blob/774013ace90033f404e02d7e29d45aa8475bbb26/modules/Movecraft/src/main/java/net/countercraft/movecraft/listener/PlayerListener.java#L107

This check is always true since e is an Event and well, events are never a Player. Also, I think this methods wants to listen for PlayerDeathEvent and not EntityDamageByEntityEvent given its name (onPlayerDeath).

SecretX33 avatar Mar 30 '24 03:03 SecretX33

That's a good catch and explains why that crafts don't sink when the player is killed.

We should just remove that listener, since it's never worked. If somebody does want the feature, we could re-add it and default it to disabled.

TylerS1066 avatar Mar 30 '24 13:03 TylerS1066