Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Redstone block updates

Open ccorp2002 opened this issue 1 year ago • 8 comments

Describe in detail what your pull request accomplishes

Redstone Block Updates/Ticking on Moving Crafts should now function. (Fire on The Move, etc, redstone clocks, etc)

Checklist

  • [x] Tested

ccorp2002 avatar Feb 13 '24 23:02 ccorp2002

This is currently not working for me on either Paper 1.18.2 or 1.20.4. I've been using this test rig: Screenshot 2024-02-23 112701

drfiveminusmint avatar Feb 23 '24 16:02 drfiveminusmint

Everything pilots fine, but the comparator clock freezes when cruising

drfiveminusmint avatar Feb 23 '24 16:02 drfiveminusmint

It was working on my machine, ill see if i can replicate it again

ccorp2002 avatar Feb 24 '24 01:02 ccorp2002

I can confirm that this works on 1.20.4, going to test it on 1.18 now

drfiveminusmint avatar Feb 25 '24 19:02 drfiveminusmint

Works on 1.18.2 too. It's a little bit hacky but it's a good starting point. 👍

drfiveminusmint avatar Feb 25 '24 20:02 drfiveminusmint

Awesome! Make sure 1.19.4 also works, if you can.

ccorp2002 avatar Feb 25 '24 20:02 ccorp2002

Can this be expanded to fire as well? Then it would fix #500 as well.

TylerS1066 avatar Mar 09 '24 15:03 TylerS1066

Testing this, it seems to somewhat work on simple redstone circuits but once the complexity goes past a simple clock it fails. In addition, in the case of a simple comparator clock, the clock seems to pause for a little bit after movement, which may be contributing the to following issues. Here's a list of things I've seen fail:

  1. Simple redstone torch burnout clock gets stuck off after movement
  2. Repeater delay line gets stuck on after movement

TylerS1066 avatar Mar 10 '24 20:03 TylerS1066