Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Incendiary toggle for ExplosionEvent

Open goodroach opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. I want torpedos and other collision-explosion craft to do some fire damage along with their typical explosion.

Describe the solution you'd like This is quite simple iirc, as all I need to do is to add a new craft config setting, add a boolean that toggles incendiary effect in ExplosionEvent, and finally add a boolean parameter to the createExplosion() method to allow for an incendiary effect.

goodroach avatar May 22 '23 23:05 goodroach

Is there a parameter for the amount of fire to use? If so, we should also include that, but I like the idea.

TylerS1066 avatar May 23 '23 00:05 TylerS1066

No, unfortunately, it's just a boolean in the createExplosion method. I personally don't think it matters that much but I can just add this feature if you like. Do you have any recommendations on my particular solution?

goodroach avatar May 23 '23 01:05 goodroach

That should cover it, my one note is to make sure that the incendiary flag is passed to the event so protection addons can work with it.

TylerS1066 avatar May 23 '23 22:05 TylerS1066

Closed in #677

TylerS1066 avatar Aug 25 '24 13:08 TylerS1066