Make ItemHarvestEvent cancellable

Open goodroach opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. Currently, there is no way to stop a craft from harvesting a block. This feature will allow you to fix issues like harvest craft harvesting blocks inside of regions or crafts. This will also provide headway to fix issue #450 as well as the issue I made in the Movecraft-Worldguard plugin.

I'm not sure how I forgot to even report this issue.

Describe the solution you'd like I'm not exactly sure how to do this, especially on what to do if the ItemHarvestEvent is cancelled. I have never created events before, but I'm interested into fixing it.

Mar 08 '23 21:03 goodroach

TranslationTask likely needs to be refactored to handle this, so it's probably best to wait for the processing rewrite. Essentially, it will need to capture the blocks to harvest, fire off the event before translation happens, and cancel movement if it is cancelled. Currently, harvesting seems to be the last step in translation.

Apr 08 '23 21:04 TylerS1066