Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Water outside of hitboxes

Open goodroach opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. Currently, water / lava can flow out of a hitbox of a ship. So allow us to turn it off. This feature will prevent ships being stuck, as well as prevent certain ships from griefing other ships by dropping water or lava on them.

Describe the solution you'd like Utilize fluidLevelChangeEvent (not sure if this is good for 1.13 but I know 1.19 is ok) to check if the fluid on event is out of the hitbox of a ship. Once the ship translates, then the water should probably disappear. Though that's going to be harder to implement.

goodroach avatar Oct 03 '22 21:10 goodroach

I believe the intent of BlockListerner#onBlockFromTo() is to do just this, but maybe it's not functioning?

TylerS1066 avatar Oct 03 '22 21:10 TylerS1066

Well currently, I can just drop water from my ship using a dispenser system onto other ships so I can completely disable it. The workaround for this currently is to make ships go through water, which isn't a problem for my server but for a server with some water it would mean all airships are submersible.

goodroach avatar Oct 03 '22 21:10 goodroach

I thought this problem was water flowing out of a craft's hitbox (like the intent of the above function), not a dispenser dispensing water outside of the hitbox. The second is much harder to detect.

TylerS1066 avatar Oct 28 '22 21:10 TylerS1066