Chunk load crash bug

[goodroach]

Describe the bug The server crashes due to Movecraft, and almost every instance of this happening, it's always the chunk loading system in Movecraft. I'm not sure why that is but here is the bug in question.

Specific instance [13:06:26] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread [13:06:26] [Paper Watchdog Thread/ERROR]: PID: 24 | Suspended: false | Native: false | State: TIMED_WAITING [13:06:26] [Paper Watchdog Thread/ERROR]: Stack: [13:06:26] [Paper Watchdog Thread/ERROR]: [email protected]/jdk.internal.misc.Unsafe.park(Native Method) [13:06:26] [Paper Watchdog Thread/ERROR]: [email protected]/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:252) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.IAsyncTaskHandler.bm(IAsyncTaskHandler.java:131) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:120) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.ChunkProviderServer.getChunkAt(ChunkProviderServer.java:536) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.IChunkProvider.getChunkAt(SourceFile:16) [13:06:26] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.CraftWorld.getChunkAt(CraftWorld.java:440) [13:06:26] [Paper Watchdog Thread/ERROR]: net.countercraft.movecraft.MovecraftChunk.toBukkit(MovecraftChunk.java:54) [13:06:26] [Paper Watchdog Thread/ERROR]: net.countercraft.movecraft.craft.ChunkManager.addChunksToLoad(ChunkManager.java:30) [13:06:26] [Paper Watchdog Thread/ERROR]: net.countercraft.movecraft.craft.ChunkManager.syncLoadChunks(ChunkManager.java:92) [13:06:26] [Paper Watchdog Thread/ERROR]: net.countercraft.movecraft.async.translation.TranslationTask.execute(TranslationTask.java:156) [13:06:26] [Paper Watchdog Thread/ERROR]: net.countercraft.movecraft.async.AsyncTask.run(AsyncTask.java:48) [13:06:26] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:101) [13:06:26] [Paper Watchdog Thread/ERROR]: app//org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:485) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1432) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:436) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1347) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1135) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:291) [13:06:26] [Paper Watchdog Thread/ERROR]: app//net.minecraft.server.v1_16_R3.MinecraftServer$$Lambda$3165/0x000000080130a988.run(Unknown Source) [13:06:26] [Paper Watchdog Thread/ERROR]: [email protected]/java.lang.Thread.run(Thread.java:831)

Versions (please complete the following information):

• Movecraft: 8.0.0 a9
• Addons: Movecraft-Combat, Movecraft-Repair, Movecraft-Worldborder
• Java 16
• Minecraft: Paper 1.16.5

Additional context I'll send the logs upon request through DMs.

[TylerS1066]

To quote ccm:

theres 2 ways to fix it

1. try to figure out all the conditions in which translation tasks can do evil things
2. rewrite translation to use the processing system

Which means that unfortunately, as I feared this will have to wait until we get to rewriting translation to use the processing system. In the mean time, do you have an estimate of how often this happens?

[ghost]

Usually it would crash every other day, during more high traffic times like ship combat we had it crash every few minutes.

[goodroach]

I can confirm, this does crash every day for us. I can help resolve this issue, if needed. I'm not sure what the "processing system" is exactly though.