Movecraft icon indicating copy to clipboard operation
Movecraft copied to clipboard

Cannot rotate multiple subcrafts using remote signs

Open galacticwarrior9 opened this issue 3 years ago • 1 comments

Describe the bug Remote signs can only rotate one subcraft. The rotation of other subcrafts will fail, stating that the "Parent Craft is busy".

To Reproduce Steps to reproduce the behavior:

  1. Build a craft with multiple turrets, each with the identically-named Subcraft Rotate signs, e.g.:
    • Line 1: Subcraft Rotate
    • Line 2: Turret
  2. Place a Remote sign that triggers these subcraft turrets, e.g.:
    • Line 1: Remote Sign
    • Line 2: Subcraft Rotate
    • Line 3: Turret
  3. Left or right-click the Remote sign.
  4. Only one of the Turret subcrafts will rotate. The rest will not, and for each of these a message stating that the "Parent Craft is busy" will be sent in chat.

Expected behavior The Remote sign should make all identically-named Subcraft Rotate crafts rotate, not just one.

Screenshots Screenshot

Versions (please complete the following information):

  • Movecraft: 8 (Alpha 6)
  • Java 17
  • Minecraft 1.18.1

Additional context

This appears to be a re-emergence of #133

The source of the issue seems to lie here. After the first subcraft rotates, the craft is set as processing for 10 ticks. But this causes all subsequent attempts to rotate subcrafts to fail due to the condition at Line 78.

galacticwarrior9 avatar Jan 20 '22 13:01 galacticwarrior9

Eventually we plan on removing the processing flag, but I'm hesitant to do so now until I learn everything it is connected to.

I suspect this may be a while until we can fix it.

TylerS1066 avatar Jan 21 '22 21:01 TylerS1066