Movecraft
Movecraft copied to clipboard
requireWaterContact should work beyond detection
Describe the bug
When requireWaterContact
is set to true
on the latest alpha, craft detection can fail due to not touching water even if the craft actually is.
To Reproduce Steps to reproduce the behavior:
- Create a craft file.
- Set
requireWaterContact
totrue
. - Create a craft of that type.
- The craft may fail to pilot if it is touching water
Expected behavior The craft should pilot.
Screenshots
Versions (please complete the following information):
- Movecraft: [e.g. 7.0.0 prerelease 6]: Movecraft 8.0.0 alpha 2
- Java [e.g. JDK 8.0.1]: 11
- Minecraft [e.g. 1.10.2]: 1.16.5; Purpur Build 1065
Additional context I've gotten it to work sometimes, but it seems to be quite inconsistent.
I think requireWaterContact
is still failing at the detection stage, before the craft is piloted and moved - I tested with the latest alpha (Movecraft 8.0.0 alpha 3) on Purpur 1.16.5, Build 1128 (latest at the time of writing):
The craft is touching the water and part of it is also submerged, but the detection is still failing. Craft file can be found here
Ah you're completely correct, the system right now appears to be only checking blocks that are part of the craft itself. I'll look into sorting that part out.