AOSSIE-Org
Issue: Toggle Theme Button Malfunction + Enhanced User Experience for "No Rooms Found" Page.
🐛 Describe the bug
Hey Developers! I found this error in the Profile > Settings > Themes, where the toggle button for the theme was not working. As provided with the media below. I would love to work on this issue.
https://github.com/user-attachments/assets/dc4690ae-a730-4da7-81cf-ff2f15471705
Other than that the initial landing page which shows "No rooms found" has a sad face with cry emoji, as its the first page the user lands on when the app is loaded, a good emoji with a positive message is necessary to maintain users mood, thus a more positive approach to the "No rooms found, but lets create on" attitude must be present.
Thus I would like to work on these issues.
Thank You, Tank0nf
Hey @dikshantbhangala, I truly appreciate your enthusiasm and willingness to contribute. Since I initially raised this issue, I’d love to take the lead on implementing the changes as I have mentioned in my issue. I’d suggest exploring other open issues where your contributions would be equally valuable. Thank you!
Hey @tank0nf, That is not a toggle button that is just the representation of the theme, we are open to suggestions for a different way of representing the theme please, feel free to suggest a new way of representing themes
@Aarush-Acharya I would actually suggest making it a toggle considering UI/UX. In the users mind, it would look like an non functioning toggle button.
I have a PR ready for this, If i can get the green signal. I will go ahead with making the PR.
I mean I had a pr but if you wish to take it forward sure go ahead @vaidika1410
@tank0nf would you like to continue work on this issue? if yes, could you please explain what kind of a change to the UI you were envisioning? As @Aarush-Acharya already mentioned the icon is not intended to be a toggle. If you could potentially show the intended changes visually that'd be great!
I want to contribute in UI enhancement of this page, is there anyone still working on it ?
@TheGoodUser please share a sample of how you would change the design before proceeding with the code and PR
Changes Made:
- Replaced toggle widgets with context-appropriate icons.
- Applied padding and border radius to ListTile for improved layout.
- Refactored code into smaller components for better readability and maintainability.
Preview
https://github.com/user-attachments/assets/5e9d0541-44d1-4659-b623-d9f7f1fa3876
Great work @TheGoodUser , I quite like the new design. However, a key change that needs to be made is that the themes need to be visible before activating them, i.e the primary and secondary color for the themes should be visible even when you open the page like the previous implementation. Also, while I like the concept of Icons representing themes, we should find alternative icons for the ones which currently are just solid bars
Changes Made:
- Theme is visible before activating them in dots, since it was confusing with toggle like widgets previously.
- Changed the alternative icon for solid bar.
Preview:
https://github.com/user-attachments/assets/bf024284-6555-48f8-9e63-0864d6cb3cb5
Hey @TheGoodUser , this representation is also good, just one small change, when the theme is selected one of more of the colors merge with the background so either remove the representation of primary, secondary, tertiary colors in dots altogether or make it so that the aren't visible for the selected theme and only visible for the others. After this change please go ahead with the PR
Yeah sure. I’ve created my PR using the simpler approach you suggested. Please review the preview.
Closing as fixed by #527 , Experience for No Rooms Found page is already as described as improved