Resonate icon indicating copy to clipboard operation
Resonate copied to clipboard
verified publisher icon AOSSIE-Org

feat: added feature to change user email address

Open vrundraval24 opened this issue 1 year ago • 1 comments

Description

Added functionality to change user email address. user will have to again verify email if they update their email address. email is changed in authentication and databases. and consistency is maintained.

Fixes #320

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I tested it in many ways and tried all possible cases. and everything works fine. and the screenshots and screen-recording of tests are added below.

Screenshots

Screenshots.zip

Screen Recording

https://github.com/AOSSIE-Org/Resonate/assets/141143426/57503cf4-55cd-4fd0-b13d-918cfae8e4cc

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tag the PR with the appropriate labels

vrundraval24 avatar Apr 07 '24 08:04 vrundraval24

Hey @vrundraval24 Looks good, great work 🚀

Suggestions

  • The email field hint says email please change that to "New Email" for making it more specific
  • For the Password field hint please make that to "Current Password"
  • In the description text "For added security you must provide a password" I believe a password might create a confusion, make it to "For added security you must provide your account password"

Also I had a doubt how will people who have logged in using OAuth providers (Google, Github) avail this functionality

Please do implement the suggested changes and push along with answering the doubt

Aarush-Acharya avatar May 09 '24 10:05 Aarush-Acharya

hey @Aarush-Acharya i made requested changes. please review it. and tell me if any changes required.

vrundraval24 avatar Jun 11 '24 11:06 vrundraval24

@vrundraval24 Looks good from my side

Aarush-Acharya avatar Jun 11 '24 11:06 Aarush-Acharya