Resonate icon indicating copy to clipboard operation
Resonate copied to clipboard

[enhance] logout icon doesn't match with app color

Open kareemabdeen opened this issue 1 year ago • 2 comments

Description

fix logout icon fades in dark theme Fixes #315

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manually in android emulator

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tag the PR with the appropriate labels

kareemabdeen avatar Mar 27 '24 20:03 kareemabdeen

@chandansgowda please check this

kareemabdeen avatar Mar 27 '24 20:03 kareemabdeen

Hey @kareemabdeen thank you for the contribution but this has already been taken care of in https://github.com/AOSSIE-Org/Resonate/pull/297

Aarush-Acharya avatar May 10 '24 07:05 Aarush-Acharya

Hey @kareemabdeen great work thank you so much for contributing, lets make resonate into a beautiful and sturdy application together.

Unfortunately this Fix was incorperated in a PR prior to this so i am closing it, but there is still a lot to be done for resonate lets work on it and evolve Resonate to the point where it should be

thank you

Aarush-Acharya avatar May 26 '24 18:05 Aarush-Acharya