Resonate icon indicating copy to clipboard operation
Resonate copied to clipboard

Fix : handle Network image load Exception in discussion tile

Open kareemabdeen opened this issue 1 year ago • 6 comments

Description

image of the user in discussion tile throw an Network Image Load Exception while user where scrolling

Fixes #300

Type of change

add on Foreground Image Error attribute to catch error throwing when loading user image

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [ ] Documentation update

How Has This Been Tested?

with my emulator

Please include screenshots below if applicable. exception thrown while user scrolling
Screenshot (1638)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tag the PR with the appropriate labels

kareemabdeen avatar Mar 15 '24 12:03 kareemabdeen

@chandansgowda Please review

kareemabdeen avatar Mar 15 '24 12:03 kareemabdeen

@chandansgowda if there's any problem on the branch please let me know

kareemabdeen avatar Mar 27 '24 20:03 kareemabdeen

Hey @kareemabdeen I tried scrolling multiple times, I do not see any error can you please elaborate on steps of reproduction of the error

Aarush-Acharya avatar May 10 '24 07:05 Aarush-Acharya

Hey @kareemabdeen I tried scrolling multiple times, I do not see any error can you please elaborate on steps of reproduction of the error

It only appears with discussion item created by user who has a custom profile picture so simply do the following Login to the app Custom ur profile picture Schedule a call to appear on discussion list Go to discussion tap and find ur discussion tile with the custom photo Observe @Aarush-Acharya

AyaNady17 avatar May 15 '24 01:05 AyaNady17

@AyaNady17 hey I am also unable to reproduce the issue. @Aarush-Acharya what about you??

vrundraval24 avatar May 23 '24 17:05 vrundraval24

Hey @AyaNady17 @vrundraval24 will do so give me some time

Aarush-Acharya avatar May 24 '24 13:05 Aarush-Acharya