Resonate icon indicating copy to clipboard operation
Resonate copied to clipboard

update : added forced app update

Open SimardeepSingh1450 opened this issue 2 years ago • 8 comments

Description

Added forced app update prompt so so as to prompt the users to force update the app when their app goes below a minimum version.

How it works ? Conditionally render the login screen only after the minimum version check has been passed using the future-builder widget, but if check is not passed then a prompt pops up which asks the user to first update the app and then use it.

Fixes #217

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally tested this app on my android device and tested the new changes as well.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tag the PR with the appropriate labels

SimardeepSingh1450 avatar Dec 26 '23 20:12 SimardeepSingh1450

@chandansgowda , so should i put it at the beginning when the app just starts ? or where do you suggest to put it ?

SimardeepSingh1450 avatar Dec 27 '23 08:12 SimardeepSingh1450

@chandansgowda ?

SimardeepSingh1450 avatar Dec 30 '23 21:12 SimardeepSingh1450

I meant, the code has to be refactored.

chandansgowda avatar Dec 31 '23 10:12 chandansgowda

@chandansgowda I have refactored the code and moved the logic to controllers, please review and merge.

SimardeepSingh1450 avatar Jan 01 '24 23:01 SimardeepSingh1450

@chandansgowda made the changes please re-review

SimardeepSingh1450 avatar Jan 05 '24 17:01 SimardeepSingh1450

@chandansgowda , sorry for the delay, but I have resolved the conflicts on the branch and can be merged now 👍

SimardeepSingh1450 avatar Feb 28 '24 06:02 SimardeepSingh1450

Hey @SimardeepSingh1450 please do the requested changes, or explain the reason for leaving it hard coded.

Resolve the conflicts to bring the PR in a stable state will merge once required changes are made

Aarush-Acharya avatar May 24 '24 11:05 Aarush-Acharya

@SimardeepSingh1450 please do the requested changes, asap and revet back please

Aarush-Acharya avatar Jul 16 '24 18:07 Aarush-Acharya