Clearing up Unused Imports & Improving Performance Closes #158
** Description **
Removed unused imports , added const where required.
** Suggestion ** I would suggest to add these things in contribution guidelines so user clears up unused imports and use const and other specific variables to improve performance.
Closes #158
@notpritam Please resolve conflicts
Hey, @chandansgowda I would love to contribute to this issue.
I have made following changes in my code...
[{ "resource": "/home/notpritam/Open Source/Resonate/lib/bindings/tabview_binding.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:resonate/controllers/authentication_controller.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 2, "startColumn": 8, "endLineNumber": 2, "endColumn": 69 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'dart:convert'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 2, "startColumn": 8, "endLineNumber": 2, "endColumn": 22 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:random_string/random_string.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 7, "startColumn": 8, "endLineNumber": 7, "endColumn": 50 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:resonate/routes/app_routes.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 9, "startColumn": 8, "endLineNumber": 9, "endColumn": 49 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:resonate/utils/constants.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 10, "startColumn": 8, "endLineNumber": 10, "endColumn": 47 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_typing_uninitialized_variables", "target": { "$mid": 1, "path": "/linter/lints/prefer_typing_uninitialized_variables.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "An uninitialized field should have an explicit type annotation.\nTry adding a type annotation.", "source": "dart", "startLineNumber": 21, "startColumn": 7, "endLineNumber": 21, "endColumn": 19 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/authentication_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_typing_uninitialized_variables", "target": { "$mid": 1, "path": "/linter/lints/prefer_typing_uninitialized_variables.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "An uninitialized field should have an explicit type annotation.\nTry adding a type annotation.", "source": "dart", "startLineNumber": 22, "startColumn": 7, "endLineNumber": 22, "endColumn": 26 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/tabview_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "override_on_non_overriding_member", "target": { "$mid": 1, "path": "/diagnostics/override_on_non_overriding_member", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "The method doesn't override an inherited method.\nTry updating this class to match the superclass, or removing the override annotation.", "source": "dart", "startLineNumber": 30, "startColumn": 8, "endLineNumber": 30, "endColumn": 17 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/create_room_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: CreateRoomScreen.kEnabledTextFieldBorder, CreateRoomScreen.kFocusedTextFieldBorder", "source": "dart", "startLineNumber": 7, "startColumn": 7, "endLineNumber": 7, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/create_room_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 7, "startColumn": 7, "endLineNumber": 7, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pair_chat_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: PairChatScreen.authStateController, PairChatScreen.controller", "source": "dart", "startLineNumber": 9, "startColumn": 7, "endLineNumber": 9, "endColumn": 21 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pair_chat_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 9, "startColumn": 7, "endLineNumber": 9, "endColumn": 21 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pair_chat_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 110, "startColumn": 15, "endLineNumber": 110, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pairing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:resonate/routes/app_routes.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 6, "startColumn": 8, "endLineNumber": 6, "endColumn": 49 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pairing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: PairingScreen.controller", "source": "dart", "startLineNumber": 11, "startColumn": 7, "endLineNumber": 11, "endColumn": 20 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pairing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 11, "startColumn": 7, "endLineNumber": 11, "endColumn": 20 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pairing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 34, "startColumn": 15, "endLineNumber": 34, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/pairing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 66, "startColumn": 15, "endLineNumber": 66, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/profile_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: ProfileScreen.authStateController", "source": "dart", "startLineNumber": 16, "startColumn": 7, "endLineNumber": 16, "endColumn": 20 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/profile_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": "todo", "severity": 2, "message": "TODO: Launch URL in webview", "source": "dart", "startLineNumber": 275, "startColumn": 31, "endLineNumber": 275, "endColumn": 58 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/profile_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": "todo", "severity": 2, "message": "TODO: Launch URL in webview", "source": "dart", "startLineNumber": 283, "startColumn": 31, "endLineNumber": 283, "endColumn": 58 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/custom_card.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:get/get.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 3, "startColumn": 8, "endLineNumber": 3, "endColumn": 30 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/participant_block.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unused_import", "target": { "$mid": 1, "path": "/diagnostics/unused_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "Unused import: 'package:get/get.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 4, "startColumn": 8, "endLineNumber": 4, "endColumn": 30 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/participant_block.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: ParticipantBlock.controller", "source": "dart", "startLineNumber": 17, "startColumn": 7, "endLineNumber": 17, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/room_tile.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "must_be_immutable", "target": { "$mid": 1, "path": "/diagnostics/must_be_immutable", "scheme": "https", "authority": "dart.dev" } }, "severity": 4, "message": "This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: RoomTile.kTileTitleStyle, RoomTile.kTileSubtitleStyle", "source": "dart", "startLineNumber": 12, "startColumn": 7, "endLineNumber": 12, "endColumn": 15 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/room_tile.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 15, "startColumn": 3, "endLineNumber": 15, "endColumn": 11 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/room_tile.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 152, "startColumn": 21, "endLineNumber": 152, "endColumn": 29 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/auth_state_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "avoid_print", "target": { "$mid": 1, "path": "/linter/lints/avoid_print.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Don't invoke 'print' in production code.\nTry using a logging framework.", "source": "dart", "startLineNumber": 72, "startColumn": 5, "endLineNumber": 72, "endColumn": 10 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/email_verify_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'otp_ID' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 80, "startColumn": 9, "endLineNumber": 80, "endColumn": 15 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/single_room_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 40, "startColumn": 26, "endLineNumber": 40, "endColumn": 53 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/single_room_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "curly_braces_in_flow_control_structures", "target": { "$mid": 1, "path": "/linter/lints/curly_braces_in_flow_control_structures.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Statements in an if should be enclosed in a block.\nTry wrapping the statement in a block.", "source": "dart", "startLineNumber": 168, "startColumn": 9, "endLineNumber": 168, "endColumn": 18 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/controllers/single_room_controller.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "curly_braces_in_flow_control_structures", "target": { "$mid": 1, "path": "/linter/lints/curly_braces_in_flow_control_structures.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Statements in an if should be enclosed in a block.\nTry wrapping the statement in a block.", "source": "dart", "startLineNumber": 170, "startColumn": 9, "endLineNumber": 170, "endColumn": 19 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/models/resonate_user.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "depend_on_referenced_packages", "target": { "$mid": 1, "path": "/linter/lints/depend_on_referenced_packages.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The imported package 'freezed_annotation' isn't a dependency of the importing package.\nTry adding a dependency for 'freezed_annotation' in the 'pubspec.yaml' file.", "source": "dart", "startLineNumber": 1, "startColumn": 8, "endLineNumber": 1, "endColumn": 60 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/models/resonate_user.g.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name '_$$ResonateUserFromJson' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 9, "startColumn": 17, "endLineNumber": 9, "endColumn": 41 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/models/resonate_user.g.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name '$$_ResonateUserToJson' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 18, "startColumn": 22, "endLineNumber": 18, "endColumn": 44 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/routes/app_pages.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 35, "startColumn": 19, "endLineNumber": 35, "endColumn": 33 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/services/room_service.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 75, "startColumn": 21, "endLineNumber": 75, "endColumn": 43 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/services/room_service.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 87, "startColumn": 21, "endLineNumber": 87, "endColumn": 43 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/email_verification_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 134, "startColumn": 43, "endLineNumber": 134, "endColumn": 75 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/email_verification_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 334, "startColumn": 46, "endLineNumber": 334, "endColumn": 80 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/email_verification_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 347, "startColumn": 43, "endLineNumber": 347, "endColumn": 53 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 23, "startColumn": 32, "endLineNumber": 25, "endColumn": 10 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 26, "startColumn": 28, "endLineNumber": 29, "endColumn": 10 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 30, "startColumn": 19, "endLineNumber": 33, "endColumn": 10 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 39, "startColumn": 25, "endLineNumber": 39, "endColumn": 37 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 138, "startColumn": 3, "endLineNumber": 138, "endColumn": 15 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImagePath' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 139, "startColumn": 19, "endLineNumber": 139, "endColumn": 28 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'InitialHeight' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 140, "startColumn": 19, "endLineNumber": 140, "endColumn": 32 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImageHeight' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 141, "startColumn": 19, "endLineNumber": 141, "endColumn": 30 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImageWidth' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 142, "startColumn": 19, "endLineNumber": 142, "endColumn": 29 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImagePath' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 144, "startColumn": 10, "endLineNumber": 144, "endColumn": 19 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'InitialHeight' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 145, "startColumn": 10, "endLineNumber": 145, "endColumn": 23 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImageHeight' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 146, "startColumn": 10, "endLineNumber": 146, "endColumn": 21 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/landing_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "non_constant_identifier_names", "target": { "$mid": 1, "path": "/linter/lints/non_constant_identifier_names.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "The variable name 'ImageWidth' isn't a lowerCamelCase identifier.\nTry changing the name to follow the lowerCamelCase style.", "source": "dart", "startLineNumber": 147, "startColumn": 10, "endLineNumber": 147, "endColumn": 20 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/login_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": "todo", "severity": 2, "message": "TODO: Navigate to forgot password screen", "source": "dart", "startLineNumber": 108, "startColumn": 25, "endLineNumber": 108, "endColumn": 65 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/login_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 182, "startColumn": 17, "endLineNumber": 182, "endColumn": 25 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/onboarding_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors_in_immutables", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors_in_immutables.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors in '@immutable' classes should be declared as 'const'.\nTry adding 'const' to the constructor declaration.", "source": "dart", "startLineNumber": 12, "startColumn": 3, "endLineNumber": 12, "endColumn": 19 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/onboarding_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 68, "startColumn": 41, "endLineNumber": 68, "endColumn": 60 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/onboarding_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 90, "startColumn": 43, "endLineNumber": 90, "endColumn": 62 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/signup_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "prefer_const_constructors", "target": { "$mid": 1, "path": "/linter/lints/prefer_const_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Use 'const' with the constructor to improve performance.\nTry adding the 'const' keyword to the constructor invocation.", "source": "dart", "startLineNumber": 211, "startColumn": 17, "endLineNumber": 211, "endColumn": 25 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/screens/tabview_screen.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "use_key_in_widget_constructors", "target": { "$mid": 1, "path": "/linter/lints/use_key_in_widget_constructors.html", "scheme": "https", "authority": "dart-lang.github.io" } }, "severity": 2, "message": "Constructors for public widgets should have a named 'key' parameter.\nTry adding a named parameter to the constructor.", "source": "dart", "startLineNumber": 17, "startColumn": 7, "endLineNumber": 17, "endColumn": 20 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/no_connection_dialog.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unnecessary_import", "target": { "$mid": 1, "path": "/diagnostics/unnecessary_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 2, "message": "The import of 'package:get/get_core/src/get_main.dart' is unnecessary because all of the used elements are also provided by the import of 'package:get/get.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 4, "startColumn": 8, "endLineNumber": 4, "endColumn": 48 },{ "resource": "/home/notpritam/Open Source/Resonate/lib/views/widgets/pair_chat_dialog.dart", "owner": "generated_diagnostic_collection_name#0", "code": { "value": "unnecessary_import", "target": { "$mid": 1, "path": "/diagnostics/unnecessary_import", "scheme": "https", "authority": "dart.dev" } }, "severity": 2, "message": "The import of 'package:get/get_core/src/get_main.dart' is unnecessary because all of the used elements are also provided by the import of 'package:get/get.dart'.\nTry removing the import directive.", "source": "dart", "startLineNumber": 5, "startColumn": 8, "endLineNumber": 5, "endColumn": 48 }]
Shall I make a PR of this?
Hey, @Aarush-Acharya @AyaNady17 I am closing this issue as this is conflicting with the main branch, and it's just a code cleanup PR.